Home > mailing lists

Thread: PATCH: Fix the issue for saving query output as CSV

PATCH: Fix the issue for saving query output as CSV

From

Murtuza Zabuawala

Date:

27 June 2016, 12:09:00

Hi,

PFA patch to fix the issue for downloading query output as CSV not working in Firefox & IE.

Also fixes the issue that HTML tags were also appended in columns title in CSV header.

Browser side fix for -> RM#1405

Regards,

Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment

RM_1405.patch

Re: PATCH: Fix the issue for saving query output as CSV

From

Dave Page

Date:

27 June 2016, 16:05:32

Hi

On Mon, Jun 27, 2016 at 1:08 PM, Murtuza Zabuawala
<murtuza.zabuawala@enterprisedb.com> wrote:
> Hi,
>
> PFA patch to fix the issue for downloading query output as CSV not working
> in Firefox & IE.
> Also fixes the issue that HTML tags were also appended in columns title in
> CSV header.
>
> Browser side fix for -> RM#1405

This works on Firefox and Chrome, but on Safari, clicking the button
does nothing.


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: PATCH: Fix the issue for saving query output as CSV

From

Murtuza Zabuawala

Date:

28 June 2016, 06:08:51

Hi Dave,

Yes, Safari is exception case because it does not support download attribute of hyperlink <a> element.

Ref:  http://caniuse.com/#feat=download

I was not able to find any workaround for Safari as of now that’s is why I mentioned only Firefox & IE in my last
email, 
Earlier it was only working on Chrome and with this patch it will work with Chrome/Firefox/IE.

Regards,
Murtuza

> On 27-Jun-2016, at 9:35 pm, Dave Page <dpage@pgadmin.org> wrote:
>
> Hi
>
> On Mon, Jun 27, 2016 at 1:08 PM, Murtuza Zabuawala
> <murtuza.zabuawala@enterprisedb.com> wrote:
>> Hi,
>>
>> PFA patch to fix the issue for downloading query output as CSV not working
>> in Firefox & IE.
>> Also fixes the issue that HTML tags were also appended in columns title in
>> CSV header.
>>
>> Browser side fix for -> RM#1405
>
> This works on Firefox and Chrome, but on Safari, clicking the button
> does nothing.
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company

Re: PATCH: Fix the issue for saving query output as CSV

From

Dave Page

Date:

28 June 2016, 09:14:19

On Tue, Jun 28, 2016 at 7:08 AM, Murtuza Zabuawala
<murtuza.zabuawala@enterprisedb.com> wrote:
> Hi Dave,
>
> Yes, Safari is exception case because it does not support download attribute of hyperlink <a> element.
>
> Ref:  http://caniuse.com/#feat=download
>
> I was not able to find any workaround for Safari as of now that’s is why I mentioned only Firefox & IE in my last
email,
> Earlier it was only working on Chrome and with this patch it will work with Chrome/Firefox/IE.

Well downloading files has been supported in browsers since NCSA
Mosaic, so it's nothing new :-). We need to fix this, one way or
another.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: PATCH: Fix the issue for saving query output as CSV

From

Murtuza Zabuawala

Date:

28 June 2016, 09:33:20

Yes Dave, I agree that downloading files has been supported in browsers since long .

But in general we send request & then receives files from web server but in our case we are fetching our data from
Backbonemodels & then converting it to CSV format for downloading as a file at client side in browser itself. 


> On 28-Jun-2016, at 2:44 pm, Dave Page <dpage@pgadmin.org> wrote:
>
> On Tue, Jun 28, 2016 at 7:08 AM, Murtuza Zabuawala
> <murtuza.zabuawala@enterprisedb.com> wrote:
>> Hi Dave,
>>
>> Yes, Safari is exception case because it does not support download attribute of hyperlink <a> element.
>>
>> Ref:  http://caniuse.com/#feat=download
>>
>> I was not able to find any workaround for Safari as of now that’s is why I mentioned only Firefox & IE in my last
email,
>> Earlier it was only working on Chrome and with this patch it will work with Chrome/Firefox/IE.
>
> Well downloading files has been supported in browsers since NCSA
> Mosaic, so it's nothing new :-). We need to fix this, one way or
> another.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company

Re: PATCH: Fix the issue for saving query output as CSV

From

Dave Page

Date:

29 June 2016, 10:10:39

On Tue, Jun 28, 2016 at 10:33 AM, Murtuza Zabuawala
<murtuza.zabuawala@enterprisedb.com> wrote:
> Yes Dave, I agree that downloading files has been supported in browsers since long .
>
> But in general we send request & then receives files from web server but in our case we are fetching our data from
Backbonemodels & then converting it to CSV format for downloading as a file at client side in browser itself. 

If Safari doesn't support client-side saving of files, then I have to
wonder if our runtime will either - both are webkit based.

So I guess the next question to ask is; why don't we just generate the
CSV on the server side?

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: PATCH: Fix the issue for saving query output as CSV

From

Murtuza Zabuawala

Date:

29 June 2016, 10:22:27

Yes, It will not work in runtime as well but I think Neel is working for fix in run time for this issue, We might able
tofix it in run time but issue persists in Safari unless they add support in browser itself. 

https://webkit.org/status/#feature-download-attribute


> On 29-Jun-2016, at 3:40 pm, Dave Page <dpage@pgadmin.org> wrote:
>
> On Tue, Jun 28, 2016 at 10:33 AM, Murtuza Zabuawala
> <murtuza.zabuawala@enterprisedb.com> wrote:
>> Yes Dave, I agree that downloading files has been supported in browsers since long .
>>
>> But in general we send request & then receives files from web server but in our case we are fetching our data from
Backbonemodels & then converting it to CSV format for downloading as a file at client side in browser itself. 
>
> If Safari doesn't support client-side saving of files, then I have to
> wonder if our runtime will either - both are webkit based.
>
> So I guess the next question to ask is; why don't we just generate the
> CSV on the server side?
>

@Akshay,
Can you please suggest on above?

> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company

Re: PATCH: Fix the issue for saving query output as CSV

From

Dave Page

Date:

29 June 2016, 10:28:37

Neel is just adding the ability to save a file rather than display it.
His work won't add the APIs to do client-side downloads - though it
will be needed to support that.

On Wed, Jun 29, 2016 at 11:22 AM, Murtuza Zabuawala
<murtuza.zabuawala@enterprisedb.com> wrote:
> Yes, It will not work in runtime as well but I think Neel is working for fix in run time for this issue, We might
ableto fix it in run time but issue persists in Safari unless they add support in browser itself. 
>
> https://webkit.org/status/#feature-download-attribute
>
>
>> On 29-Jun-2016, at 3:40 pm, Dave Page <dpage@pgadmin.org> wrote:
>>
>> On Tue, Jun 28, 2016 at 10:33 AM, Murtuza Zabuawala
>> <murtuza.zabuawala@enterprisedb.com> wrote:
>>> Yes Dave, I agree that downloading files has been supported in browsers since long .
>>>
>>> But in general we send request & then receives files from web server but in our case we are fetching our data from
Backbonemodels & then converting it to CSV format for downloading as a file at client side in browser itself. 
>>
>> If Safari doesn't support client-side saving of files, then I have to
>> wonder if our runtime will either - both are webkit based.
>>
>> So I guess the next question to ask is; why don't we just generate the
>> CSV on the server side?
>>
>
> @Akshay,
> Can you please suggest on above?
>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: PATCH: Fix the issue for saving query output as CSV

From

Akshay Joshi

Date:

29 June 2016, 11:23:34

On Wed, Jun 29, 2016 at 3:52 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

Yes, It will not work in runtime as well but I think Neel is working for fix in run time for this issue, We might able to fix it in run time but issue persists in Safari unless they add support in browser itself.

https://webkit.org/status/#feature-download-attribute

> On 29-Jun-2016, at 3:40 pm, Dave Page <dpage@pgadmin.org> wrote:
>
> On Tue, Jun 28, 2016 at 10:33 AM, Murtuza Zabuawala
> <murtuza.zabuawala@enterprisedb.com> wrote:
>> Yes Dave, I agree that downloading files has been supported in browsers since long .
>>
>> But in general we send request & then receives files from web server but in our case we are fetching our data from Backbone models & then converting it to CSV format for downloading as a file at client side in browser itself.
>
> If Safari doesn't support client-side saving of files, then I have to
> wonder if our runtime will either - both are webkit based.
>
> So I guess the next question to ask is; why don't we just generate the
> CSV on the server side?
>

@Akshay,
Can you please suggest on above?

As we already have complete data in backgrid's full collection, so I have used it instead of fetching it again.

> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Akshay Joshi

Principal Software Engineer

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246

Re: PATCH: Fix the issue for saving query output as CSV

From

Harshal Dhumal

Date:

11 July 2016, 08:16:23

Hi,

PFA patch for RM1405. Also to allow download in runtime we will still need patch sent by Neel.

Changes: To download query result to CSV directly from server and not to use download attr. of anchor tag (<a>) as it's not support by all of major browsers (e.g. Safari).
Also it's not feasible to load data in html to download if result set of query is very huge (in GBs).

Harshal Dhumal

Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Wed, Jun 29, 2016 at 4:53 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

On Wed, Jun 29, 2016 at 3:52 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Yes, It will not work in runtime as well but I think Neel is working for fix in run time for this issue, We might able to fix it in run time but issue persists in Safari unless they add support in browser itself.

https://webkit.org/status/#feature-download-attribute

> On 29-Jun-2016, at 3:40 pm, Dave Page <dpage@pgadmin.org> wrote:
>
> On Tue, Jun 28, 2016 at 10:33 AM, Murtuza Zabuawala
> <murtuza.zabuawala@enterprisedb.com> wrote:
>> Yes Dave, I agree that downloading files has been supported in browsers since long .
>>
>> But in general we send request & then receives files from web server but in our case we are fetching our data from Backbone models & then converting it to CSV format for downloading as a file at client side in browser itself.
>
> If Safari doesn't support client-side saving of files, then I have to
> wonder if our runtime will either - both are webkit based.
>
> So I guess the next question to ask is; why don't we just generate the
> CSV on the server side?
>

@Akshay,
Can you please suggest on above?

As we already have complete data in backgrid's full collection, so I have used it instead of fetching it again.

> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

--
Akshay Joshi
Principal Software Engineer

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246

Attachment

RM1405_V2_download_query_result_to_csv_server_side.patch

Re: PATCH: Fix the issue for saving query output as CSV

From

Dave Page

Date:

13 July 2016, 11:40:07

Can you rebase this please?

Thanks.

On Mon, Jul 11, 2016 at 9:16 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:

Hi,

PFA patch for RM1405. Also to allow download in runtime we will still need patch sent by Neel.

Changes: To download query result to CSV directly from server and not to use download attr. of anchor tag (<a>) as it's not support by all of major browsers (e.g. Safari).
Also it's not feasible to load data in html to download if result set of query is very huge (in GBs).

--
Harshal Dhumal
Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Wed, Jun 29, 2016 at 4:53 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

On Wed, Jun 29, 2016 at 3:52 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Yes, It will not work in runtime as well but I think Neel is working for fix in run time for this issue, We might able to fix it in run time but issue persists in Safari unless they add support in browser itself.

https://webkit.org/status/#feature-download-attribute

> On 29-Jun-2016, at 3:40 pm, Dave Page <dpage@pgadmin.org> wrote:
>
> On Tue, Jun 28, 2016 at 10:33 AM, Murtuza Zabuawala
> <murtuza.zabuawala@enterprisedb.com> wrote:
>> Yes Dave, I agree that downloading files has been supported in browsers since long .
>>
>> But in general we send request & then receives files from web server but in our case we are fetching our data from Backbone models & then converting it to CSV format for downloading as a file at client side in browser itself.
>
> If Safari doesn't support client-side saving of files, then I have to
> wonder if our runtime will either - both are webkit based.
>
> So I guess the next question to ask is; why don't we just generate the
> CSV on the server side?
>

@Akshay,
Can you please suggest on above?

As we already have complete data in backgrid's full collection, so I have used it instead of fetching it again.

> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

--
Akshay Joshi
Principal Software Engineer

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: PATCH: Fix the issue for saving query output as CSV

From

Harshal Dhumal

Date:

13 July 2016, 11:45:50

Yes sure

Harshal Dhumal

Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Wed, Jul 13, 2016 at 5:10 PM, Dave Page <dpage@pgadmin.org> wrote:

Hi

Can you rebase this please?

Thanks.

On Mon, Jul 11, 2016 at 9:16 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi,

PFA patch for RM1405. Also to allow download in runtime we will still need patch sent by Neel.

Changes: To download query result to CSV directly from server and not to use download attr. of anchor tag (<a>) as it's not support by all of major browsers (e.g. Safari).
Also it's not feasible to load data in html to download if result set of query is very huge (in GBs).

--
Harshal Dhumal
Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Wed, Jun 29, 2016 at 4:53 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

On Wed, Jun 29, 2016 at 3:52 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Yes, It will not work in runtime as well but I think Neel is working for fix in run time for this issue, We might able to fix it in run time but issue persists in Safari unless they add support in browser itself.

https://webkit.org/status/#feature-download-attribute

> On 29-Jun-2016, at 3:40 pm, Dave Page <dpage@pgadmin.org> wrote:
>
> On Tue, Jun 28, 2016 at 10:33 AM, Murtuza Zabuawala
> <murtuza.zabuawala@enterprisedb.com> wrote:
>> Yes Dave, I agree that downloading files has been supported in browsers since long .
>>
>> But in general we send request & then receives files from web server but in our case we are fetching our data from Backbone models & then converting it to CSV format for downloading as a file at client side in browser itself.
>
> If Safari doesn't support client-side saving of files, then I have to
> wonder if our runtime will either - both are webkit based.
>
> So I guess the next question to ask is; why don't we just generate the
> CSV on the server side?
>

@Akshay,
Can you please suggest on above?

As we already have complete data in backgrid's full collection, so I have used it instead of fetching it again.

> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

--
Akshay Joshi
Principal Software Engineer

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: PATCH: Fix the issue for saving query output as CSV

From

Harshal Dhumal

Date:

13 July 2016, 12:16:48

Hi,

PFA rebased patch for RM1405

Harshal Dhumal

Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Wed, Jul 13, 2016 at 5:15 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:

Yes sure

--
Harshal Dhumal
Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Wed, Jul 13, 2016 at 5:10 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

Can you rebase this please?

Thanks.

On Mon, Jul 11, 2016 at 9:16 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi,

PFA patch for RM1405. Also to allow download in runtime we will still need patch sent by Neel.

Changes: To download query result to CSV directly from server and not to use download attr. of anchor tag (<a>) as it's not support by all of major browsers (e.g. Safari).
Also it's not feasible to load data in html to download if result set of query is very huge (in GBs).

--
Harshal Dhumal
Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Wed, Jun 29, 2016 at 4:53 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

On Wed, Jun 29, 2016 at 3:52 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Yes, It will not work in runtime as well but I think Neel is working for fix in run time for this issue, We might able to fix it in run time but issue persists in Safari unless they add support in browser itself.

https://webkit.org/status/#feature-download-attribute

> On 29-Jun-2016, at 3:40 pm, Dave Page <dpage@pgadmin.org> wrote:
>
> On Tue, Jun 28, 2016 at 10:33 AM, Murtuza Zabuawala
> <murtuza.zabuawala@enterprisedb.com> wrote:
>> Yes Dave, I agree that downloading files has been supported in browsers since long .
>>
>> But in general we send request & then receives files from web server but in our case we are fetching our data from Backbone models & then converting it to CSV format for downloading as a file at client side in browser itself.
>
> If Safari doesn't support client-side saving of files, then I have to
> wonder if our runtime will either - both are webkit based.
>
> So I guess the next question to ask is; why don't we just generate the
> CSV on the server side?
>

@Akshay,
Can you please suggest on above?

As we already have complete data in backgrid's full collection, so I have used it instead of fetching it again.

> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

--
Akshay Joshi
Principal Software Engineer

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment

RM1405_V3_download_query_result_to_csv_server_side.patch

Re: PATCH: Fix the issue for saving query output as CSV

From

Dave Page

Date:

15 July 2016, 09:35:28

This seems to break downloads in the runtime. It works in Safari and Chrome, but in the runtime the suggested filename is "6980287?query=SELECT+*+FROM+pem.probe_column%0AORDER+BY+id%0AASC+&filename=probe_column.csv", and after changing that and hitting OK, the "Downloading file" dialogue is shown indefinitely.

On Wed, Jul 13, 2016 at 1:16 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:

Hi,

PFA rebased patch for RM1405

--
Harshal Dhumal
Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Wed, Jul 13, 2016 at 5:15 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Yes sure

--
Harshal Dhumal
Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Wed, Jul 13, 2016 at 5:10 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

Can you rebase this please?

Thanks.

On Mon, Jul 11, 2016 at 9:16 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi,

PFA patch for RM1405. Also to allow download in runtime we will still need patch sent by Neel.

Changes: To download query result to CSV directly from server and not to use download attr. of anchor tag (<a>) as it's not support by all of major browsers (e.g. Safari).
Also it's not feasible to load data in html to download if result set of query is very huge (in GBs).

--
Harshal Dhumal
Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Wed, Jun 29, 2016 at 4:53 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

On Wed, Jun 29, 2016 at 3:52 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Yes, It will not work in runtime as well but I think Neel is working for fix in run time for this issue, We might able to fix it in run time but issue persists in Safari unless they add support in browser itself.

https://webkit.org/status/#feature-download-attribute

> On 29-Jun-2016, at 3:40 pm, Dave Page <dpage@pgadmin.org> wrote:
>
> On Tue, Jun 28, 2016 at 10:33 AM, Murtuza Zabuawala
> <murtuza.zabuawala@enterprisedb.com> wrote:
>> Yes Dave, I agree that downloading files has been supported in browsers since long .
>>
>> But in general we send request & then receives files from web server but in our case we are fetching our data from Backbone models & then converting it to CSV format for downloading as a file at client side in browser itself.
>
> If Safari doesn't support client-side saving of files, then I have to
> wonder if our runtime will either - both are webkit based.
>
> So I guess the next question to ask is; why don't we just generate the
> CSV on the server side?
>

@Akshay,
Can you please suggest on above?

As we already have complete data in backgrid's full collection, so I have used it instead of fetching it again.

> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

--
Akshay Joshi
Principal Software Engineer

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: PATCH: Fix the issue for saving query output as CSV

From

Neel Patel

Date:

18 July 2016, 09:42:59

Hi Dave,

Yes, it will break in runtime. If we need to support downloading at server side then we need to change the runtime code.

I will send the patch for runtime to support server side download CSV file.

Thanks,

Neel Patel

On Fri, Jul 15, 2016 at 3:05 PM, Dave Page <dpage@pgadmin.org> wrote:

Hi

This seems to break downloads in the runtime. It works in Safari and Chrome, but in the runtime the suggested filename is "6980287?query=SELECT+*+FROM+pem.probe_column%0AORDER+BY+id%0AASC+&filename=probe_column.csv", and after changing that and hitting OK, the "Downloading file" dialogue is shown indefinitely.

On Wed, Jul 13, 2016 at 1:16 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi,

PFA rebased patch for RM1405

--
Harshal Dhumal
Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Wed, Jul 13, 2016 at 5:15 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Yes sure

--
Harshal Dhumal
Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Wed, Jul 13, 2016 at 5:10 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

Can you rebase this please?

Thanks.

On Mon, Jul 11, 2016 at 9:16 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi,

PFA patch for RM1405. Also to allow download in runtime we will still need patch sent by Neel.

Changes: To download query result to CSV directly from server and not to use download attr. of anchor tag (<a>) as it's not support by all of major browsers (e.g. Safari).
Also it's not feasible to load data in html to download if result set of query is very huge (in GBs).

--
Harshal Dhumal
Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Wed, Jun 29, 2016 at 4:53 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

On Wed, Jun 29, 2016 at 3:52 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Yes, It will not work in runtime as well but I think Neel is working for fix in run time for this issue, We might able to fix it in run time but issue persists in Safari unless they add support in browser itself.

https://webkit.org/status/#feature-download-attribute

> On 29-Jun-2016, at 3:40 pm, Dave Page <dpage@pgadmin.org> wrote:
>
> On Tue, Jun 28, 2016 at 10:33 AM, Murtuza Zabuawala
> <murtuza.zabuawala@enterprisedb.com> wrote:
>> Yes Dave, I agree that downloading files has been supported in browsers since long .
>>
>> But in general we send request & then receives files from web server but in our case we are fetching our data from Backbone models & then converting it to CSV format for downloading as a file at client side in browser itself.
>
> If Safari doesn't support client-side saving of files, then I have to
> wonder if our runtime will either - both are webkit based.
>
> So I guess the next question to ask is; why don't we just generate the
> CSV on the server side?
>

@Akshay,
Can you please suggest on above?

As we already have complete data in backgrid's full collection, so I have used it instead of fetching it again.

> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

--
Akshay Joshi
Principal Software Engineer

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: PATCH: Fix the issue for saving query output as CSV

From

Dave Page

Date:

18 July 2016, 10:18:33

Thanks!

On Mon, Jul 18, 2016 at 10:42 AM, Neel Patel <neel.patel@enterprisedb.com> wrote:

Hi Dave,

Yes, it will break in runtime. If we need to support downloading at server side then we need to change the runtime code.
I will send the patch for runtime to support server side download CSV file.

Thanks,
Neel Patel

On Fri, Jul 15, 2016 at 3:05 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

This seems to break downloads in the runtime. It works in Safari and Chrome, but in the runtime the suggested filename is "6980287?query=SELECT+*+FROM+pem.probe_column%0AORDER+BY+id%0AASC+&filename=probe_column.csv", and after changing that and hitting OK, the "Downloading file" dialogue is shown indefinitely.

On Wed, Jul 13, 2016 at 1:16 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi,

PFA rebased patch for RM1405

--
Harshal Dhumal
Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Wed, Jul 13, 2016 at 5:15 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Yes sure

--
Harshal Dhumal
Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Wed, Jul 13, 2016 at 5:10 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

Can you rebase this please?

Thanks.

On Mon, Jul 11, 2016 at 9:16 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi,

PFA patch for RM1405. Also to allow download in runtime we will still need patch sent by Neel.

Changes: To download query result to CSV directly from server and not to use download attr. of anchor tag (<a>) as it's not support by all of major browsers (e.g. Safari).
Also it's not feasible to load data in html to download if result set of query is very huge (in GBs).

--
Harshal Dhumal
Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Wed, Jun 29, 2016 at 4:53 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

On Wed, Jun 29, 2016 at 3:52 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Yes, It will not work in runtime as well but I think Neel is working for fix in run time for this issue, We might able to fix it in run time but issue persists in Safari unless they add support in browser itself.

https://webkit.org/status/#feature-download-attribute

> On 29-Jun-2016, at 3:40 pm, Dave Page <dpage@pgadmin.org> wrote:
>
> On Tue, Jun 28, 2016 at 10:33 AM, Murtuza Zabuawala
> <murtuza.zabuawala@enterprisedb.com> wrote:
>> Yes Dave, I agree that downloading files has been supported in browsers since long .
>>
>> But in general we send request & then receives files from web server but in our case we are fetching our data from Backbone models & then converting it to CSV format for downloading as a file at client side in browser itself.
>
> If Safari doesn't support client-side saving of files, then I have to
> wonder if our runtime will either - both are webkit based.
>
> So I guess the next question to ask is; why don't we just generate the
> CSV on the server side?
>

@Akshay,
Can you please suggest on above?

As we already have complete data in backgrid's full collection, so I have used it instead of fetching it again.

> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

--
Akshay Joshi
Principal Software Engineer

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: PATCH: Fix the issue for saving query output as CSV

From

Dave Page

Date:

18 July 2016, 10:23:33

Any chance of getting that in the next couple of hours so I can get it into beta 3?

On Mon, Jul 18, 2016 at 11:18 AM, Dave Page <dpage@pgadmin.org> wrote:

Thanks!

On Mon, Jul 18, 2016 at 10:42 AM, Neel Patel <neel.patel@enterprisedb.com> wrote:
Hi Dave,

Yes, it will break in runtime. If we need to support downloading at server side then we need to change the runtime code.
I will send the patch for runtime to support server side download CSV file.

Thanks,
Neel Patel

On Fri, Jul 15, 2016 at 3:05 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

This seems to break downloads in the runtime. It works in Safari and Chrome, but in the runtime the suggested filename is "6980287?query=SELECT+*+FROM+pem.probe_column%0AORDER+BY+id%0AASC+&filename=probe_column.csv", and after changing that and hitting OK, the "Downloading file" dialogue is shown indefinitely.

On Wed, Jul 13, 2016 at 1:16 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi,

PFA rebased patch for RM1405

--
Harshal Dhumal
Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Wed, Jul 13, 2016 at 5:15 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Yes sure

--
Harshal Dhumal
Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Wed, Jul 13, 2016 at 5:10 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

Can you rebase this please?

Thanks.

On Mon, Jul 11, 2016 at 9:16 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi,

PFA patch for RM1405. Also to allow download in runtime we will still need patch sent by Neel.

Changes: To download query result to CSV directly from server and not to use download attr. of anchor tag (<a>) as it's not support by all of major browsers (e.g. Safari).
Also it's not feasible to load data in html to download if result set of query is very huge (in GBs).

--
Harshal Dhumal
Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Wed, Jun 29, 2016 at 4:53 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

On Wed, Jun 29, 2016 at 3:52 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Yes, It will not work in runtime as well but I think Neel is working for fix in run time for this issue, We might able to fix it in run time but issue persists in Safari unless they add support in browser itself.

https://webkit.org/status/#feature-download-attribute

> On 29-Jun-2016, at 3:40 pm, Dave Page <dpage@pgadmin.org> wrote:
>
> On Tue, Jun 28, 2016 at 10:33 AM, Murtuza Zabuawala
> <murtuza.zabuawala@enterprisedb.com> wrote:
>> Yes Dave, I agree that downloading files has been supported in browsers since long .
>>
>> But in general we send request & then receives files from web server but in our case we are fetching our data from Backbone models & then converting it to CSV format for downloading as a file at client side in browser itself.
>
> If Safari doesn't support client-side saving of files, then I have to
> wonder if our runtime will either - both are webkit based.
>
> So I guess the next question to ask is; why don't we just generate the
> CSV on the server side?
>

@Akshay,
Can you please suggest on above?

As we already have complete data in backgrid's full collection, so I have used it instead of fetching it again.

> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

--
Akshay Joshi
Principal Software Engineer

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: PATCH: Fix the issue for saving query output as CSV

From

Neel Patel

Date:

18 July 2016, 10:25:05

Yes. I am just testing with different OS. I will send it next 1-2 hour.

Is it fine ?

Thanks,

Neel Patel

On Mon, Jul 18, 2016 at 3:53 PM, Dave Page <dpage@pgadmin.org> wrote:

Any chance of getting that in the next couple of hours so I can get it into beta 3?

On Mon, Jul 18, 2016 at 11:18 AM, Dave Page <dpage@pgadmin.org> wrote:
Thanks!

On Mon, Jul 18, 2016 at 10:42 AM, Neel Patel <neel.patel@enterprisedb.com> wrote:
Hi Dave,

Yes, it will break in runtime. If we need to support downloading at server side then we need to change the runtime code.
I will send the patch for runtime to support server side download CSV file.

Thanks,
Neel Patel

On Fri, Jul 15, 2016 at 3:05 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

This seems to break downloads in the runtime. It works in Safari and Chrome, but in the runtime the suggested filename is "6980287?query=SELECT+*+FROM+pem.probe_column%0AORDER+BY+id%0AASC+&filename=probe_column.csv", and after changing that and hitting OK, the "Downloading file" dialogue is shown indefinitely.

On Wed, Jul 13, 2016 at 1:16 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi,

PFA rebased patch for RM1405

--
Harshal Dhumal
Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Wed, Jul 13, 2016 at 5:15 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Yes sure

--
Harshal Dhumal
Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Wed, Jul 13, 2016 at 5:10 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

Can you rebase this please?

Thanks.

On Mon, Jul 11, 2016 at 9:16 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi,

PFA patch for RM1405. Also to allow download in runtime we will still need patch sent by Neel.

Changes: To download query result to CSV directly from server and not to use download attr. of anchor tag (<a>) as it's not support by all of major browsers (e.g. Safari).
Also it's not feasible to load data in html to download if result set of query is very huge (in GBs).

--
Harshal Dhumal
Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Wed, Jun 29, 2016 at 4:53 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

On Wed, Jun 29, 2016 at 3:52 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Yes, It will not work in runtime as well but I think Neel is working for fix in run time for this issue, We might able to fix it in run time but issue persists in Safari unless they add support in browser itself.

https://webkit.org/status/#feature-download-attribute

> On 29-Jun-2016, at 3:40 pm, Dave Page <dpage@pgadmin.org> wrote:
>
> On Tue, Jun 28, 2016 at 10:33 AM, Murtuza Zabuawala
> <murtuza.zabuawala@enterprisedb.com> wrote:
>> Yes Dave, I agree that downloading files has been supported in browsers since long .
>>
>> But in general we send request & then receives files from web server but in our case we are fetching our data from Backbone models & then converting it to CSV format for downloading as a file at client side in browser itself.
>
> If Safari doesn't support client-side saving of files, then I have to
> wonder if our runtime will either - both are webkit based.
>
> So I guess the next question to ask is; why don't we just generate the
> CSV on the server side?
>

@Akshay,
Can you please suggest on above?

As we already have complete data in backgrid's full collection, so I have used it instead of fetching it again.

> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

--
Akshay Joshi
Principal Software Engineer

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: PATCH: Fix the issue for saving query output as CSV

From

Dave Page

Date:

18 July 2016, 10:32:11

Perfect, thanks!

On Mon, Jul 18, 2016 at 11:24 AM, Neel Patel <neel.patel@enterprisedb.com> wrote:

Yes. I am just testing with different OS. I will send it next 1-2 hour.

Is it fine ?

Thanks,
Neel Patel

On Mon, Jul 18, 2016 at 3:53 PM, Dave Page <dpage@pgadmin.org> wrote:
Any chance of getting that in the next couple of hours so I can get it into beta 3?

On Mon, Jul 18, 2016 at 11:18 AM, Dave Page <dpage@pgadmin.org> wrote:
Thanks!

On Mon, Jul 18, 2016 at 10:42 AM, Neel Patel <neel.patel@enterprisedb.com> wrote:
Hi Dave,

Yes, it will break in runtime. If we need to support downloading at server side then we need to change the runtime code.
I will send the patch for runtime to support server side download CSV file.

Thanks,
Neel Patel

On Fri, Jul 15, 2016 at 3:05 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

This seems to break downloads in the runtime. It works in Safari and Chrome, but in the runtime the suggested filename is "6980287?query=SELECT+*+FROM+pem.probe_column%0AORDER+BY+id%0AASC+&filename=probe_column.csv", and after changing that and hitting OK, the "Downloading file" dialogue is shown indefinitely.

On Wed, Jul 13, 2016 at 1:16 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi,

PFA rebased patch for RM1405

--
Harshal Dhumal
Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Wed, Jul 13, 2016 at 5:15 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Yes sure

--
Harshal Dhumal
Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Wed, Jul 13, 2016 at 5:10 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

Can you rebase this please?

Thanks.

On Mon, Jul 11, 2016 at 9:16 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi,

PFA patch for RM1405. Also to allow download in runtime we will still need patch sent by Neel.

Changes: To download query result to CSV directly from server and not to use download attr. of anchor tag (<a>) as it's not support by all of major browsers (e.g. Safari).
Also it's not feasible to load data in html to download if result set of query is very huge (in GBs).

--
Harshal Dhumal
Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Wed, Jun 29, 2016 at 4:53 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

On Wed, Jun 29, 2016 at 3:52 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Yes, It will not work in runtime as well but I think Neel is working for fix in run time for this issue, We might able to fix it in run time but issue persists in Safari unless they add support in browser itself.

https://webkit.org/status/#feature-download-attribute

> On 29-Jun-2016, at 3:40 pm, Dave Page <dpage@pgadmin.org> wrote:
>
> On Tue, Jun 28, 2016 at 10:33 AM, Murtuza Zabuawala
> <murtuza.zabuawala@enterprisedb.com> wrote:
>> Yes Dave, I agree that downloading files has been supported in browsers since long .
>>
>> But in general we send request & then receives files from web server but in our case we are fetching our data from Backbone models & then converting it to CSV format for downloading as a file at client side in browser itself.
>
> If Safari doesn't support client-side saving of files, then I have to
> wonder if our runtime will either - both are webkit based.
>
> So I guess the next question to ask is; why don't we just generate the
> CSV on the server side?
>

@Akshay,
Can you please suggest on above?

As we already have complete data in backgrid's full collection, so I have used it instead of fetching it again.

> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

--
Akshay Joshi
Principal Software Engineer

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: PATCH: Fix the issue for saving query output as CSV

From

Harshal Dhumal

Date:

18 July 2016, 12:01:23

Hi,

PFA rebased patch RM1405 (version 4)

Neel will be sending patch for QT issue for same functionality.

Harshal Dhumal

Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Mon, Jul 18, 2016 at 4:02 PM, Dave Page <dpage@pgadmin.org> wrote:

Perfect, thanks!

On Mon, Jul 18, 2016 at 11:24 AM, Neel Patel <neel.patel@enterprisedb.com> wrote:
Yes. I am just testing with different OS. I will send it next 1-2 hour.

Is it fine ?

Thanks,
Neel Patel

On Mon, Jul 18, 2016 at 3:53 PM, Dave Page <dpage@pgadmin.org> wrote:
Any chance of getting that in the next couple of hours so I can get it into beta 3?

On Mon, Jul 18, 2016 at 11:18 AM, Dave Page <dpage@pgadmin.org> wrote:
Thanks!

On Mon, Jul 18, 2016 at 10:42 AM, Neel Patel <neel.patel@enterprisedb.com> wrote:
Hi Dave,

Yes, it will break in runtime. If we need to support downloading at server side then we need to change the runtime code.
I will send the patch for runtime to support server side download CSV file.

Thanks,
Neel Patel

On Fri, Jul 15, 2016 at 3:05 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

This seems to break downloads in the runtime. It works in Safari and Chrome, but in the runtime the suggested filename is "6980287?query=SELECT+*+FROM+pem.probe_column%0AORDER+BY+id%0AASC+&filename=probe_column.csv", and after changing that and hitting OK, the "Downloading file" dialogue is shown indefinitely.

On Wed, Jul 13, 2016 at 1:16 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi,

PFA rebased patch for RM1405

--
Harshal Dhumal
Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Wed, Jul 13, 2016 at 5:15 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Yes sure

--
Harshal Dhumal
Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Wed, Jul 13, 2016 at 5:10 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

Can you rebase this please?

Thanks.

On Mon, Jul 11, 2016 at 9:16 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi,

PFA patch for RM1405. Also to allow download in runtime we will still need patch sent by Neel.

Changes: To download query result to CSV directly from server and not to use download attr. of anchor tag (<a>) as it's not support by all of major browsers (e.g. Safari).
Also it's not feasible to load data in html to download if result set of query is very huge (in GBs).

--
Harshal Dhumal
Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Wed, Jun 29, 2016 at 4:53 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

On Wed, Jun 29, 2016 at 3:52 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Yes, It will not work in runtime as well but I think Neel is working for fix in run time for this issue, We might able to fix it in run time but issue persists in Safari unless they add support in browser itself.

https://webkit.org/status/#feature-download-attribute

> On 29-Jun-2016, at 3:40 pm, Dave Page <dpage@pgadmin.org> wrote:
>
> On Tue, Jun 28, 2016 at 10:33 AM, Murtuza Zabuawala
> <murtuza.zabuawala@enterprisedb.com> wrote:
>> Yes Dave, I agree that downloading files has been supported in browsers since long .
>>
>> But in general we send request & then receives files from web server but in our case we are fetching our data from Backbone models & then converting it to CSV format for downloading as a file at client side in browser itself.
>
> If Safari doesn't support client-side saving of files, then I have to
> wonder if our runtime will either - both are webkit based.
>
> So I guess the next question to ask is; why don't we just generate the
> CSV on the server side?
>

@Akshay,
Can you please suggest on above?

As we already have complete data in backgrid's full collection, so I have used it instead of fetching it again.

> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

--
Akshay Joshi
Principal Software Engineer

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment

RM1405_V4_download_query_result_to_csv_server_side.patch

Re: PATCH: Fix the issue for saving query output as CSV

From

Neel Patel

Date:

18 July 2016, 12:27:24

Hi,

Please find attached patch file to support server side download in runtime application.

NOTE: Before applying this patch, use above harshal's patch.

Thanks,

Neel Patel

On Mon, Jul 18, 2016 at 5:31 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:

Hi,

PFA rebased patch RM1405 (version 4)

Neel will be sending patch for QT issue for same functionality.

--
Harshal Dhumal
Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Mon, Jul 18, 2016 at 4:02 PM, Dave Page <dpage@pgadmin.org> wrote:
Perfect, thanks!

On Mon, Jul 18, 2016 at 11:24 AM, Neel Patel <neel.patel@enterprisedb.com> wrote:
Yes. I am just testing with different OS. I will send it next 1-2 hour.

Is it fine ?

Thanks,
Neel Patel

On Mon, Jul 18, 2016 at 3:53 PM, Dave Page <dpage@pgadmin.org> wrote:
Any chance of getting that in the next couple of hours so I can get it into beta 3?

On Mon, Jul 18, 2016 at 11:18 AM, Dave Page <dpage@pgadmin.org> wrote:
Thanks!

On Mon, Jul 18, 2016 at 10:42 AM, Neel Patel <neel.patel@enterprisedb.com> wrote:
Hi Dave,

Yes, it will break in runtime. If we need to support downloading at server side then we need to change the runtime code.
I will send the patch for runtime to support server side download CSV file.

Thanks,
Neel Patel

On Fri, Jul 15, 2016 at 3:05 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

This seems to break downloads in the runtime. It works in Safari and Chrome, but in the runtime the suggested filename is "6980287?query=SELECT+*+FROM+pem.probe_column%0AORDER+BY+id%0AASC+&filename=probe_column.csv", and after changing that and hitting OK, the "Downloading file" dialogue is shown indefinitely.

On Wed, Jul 13, 2016 at 1:16 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi,

PFA rebased patch for RM1405

--
Harshal Dhumal
Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Wed, Jul 13, 2016 at 5:15 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Yes sure

--
Harshal Dhumal
Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Wed, Jul 13, 2016 at 5:10 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

Can you rebase this please?

Thanks.

On Mon, Jul 11, 2016 at 9:16 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi,

PFA patch for RM1405. Also to allow download in runtime we will still need patch sent by Neel.

Changes: To download query result to CSV directly from server and not to use download attr. of anchor tag (<a>) as it's not support by all of major browsers (e.g. Safari).
Also it's not feasible to load data in html to download if result set of query is very huge (in GBs).

--
Harshal Dhumal
Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Wed, Jun 29, 2016 at 4:53 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

On Wed, Jun 29, 2016 at 3:52 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Yes, It will not work in runtime as well but I think Neel is working for fix in run time for this issue, We might able to fix it in run time but issue persists in Safari unless they add support in browser itself.

https://webkit.org/status/#feature-download-attribute

> On 29-Jun-2016, at 3:40 pm, Dave Page <dpage@pgadmin.org> wrote:
>
> On Tue, Jun 28, 2016 at 10:33 AM, Murtuza Zabuawala
> <murtuza.zabuawala@enterprisedb.com> wrote:
>> Yes Dave, I agree that downloading files has been supported in browsers since long .
>>
>> But in general we send request & then receives files from web server but in our case we are fetching our data from Backbone models & then converting it to CSV format for downloading as a file at client side in browser itself.
>
> If Safari doesn't support client-side saving of files, then I have to
> wonder if our runtime will either - both are webkit based.
>
> So I guess the next question to ask is; why don't we just generate the
> CSV on the server side?
>

@Akshay,
Can you please suggest on above?

As we already have complete data in backgrid's full collection, so I have used it instead of fetching it again.

> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

--
Akshay Joshi
Principal Software Engineer

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment

runtime_server_download.patch

Re: PATCH: Fix the issue for saving query output as CSV

From

Dave Page

Date:

18 July 2016, 14:29:30

Thanks, applied.

On Mon, Jul 18, 2016 at 1:01 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:

Hi,

PFA rebased patch RM1405 (version 4)

Neel will be sending patch for QT issue for same functionality.

--
Harshal Dhumal
Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Mon, Jul 18, 2016 at 4:02 PM, Dave Page <dpage@pgadmin.org> wrote:
Perfect, thanks!

On Mon, Jul 18, 2016 at 11:24 AM, Neel Patel <neel.patel@enterprisedb.com> wrote:
Yes. I am just testing with different OS. I will send it next 1-2 hour.

Is it fine ?

Thanks,
Neel Patel

On Mon, Jul 18, 2016 at 3:53 PM, Dave Page <dpage@pgadmin.org> wrote:
Any chance of getting that in the next couple of hours so I can get it into beta 3?

On Mon, Jul 18, 2016 at 11:18 AM, Dave Page <dpage@pgadmin.org> wrote:
Thanks!

On Mon, Jul 18, 2016 at 10:42 AM, Neel Patel <neel.patel@enterprisedb.com> wrote:
Hi Dave,

Yes, it will break in runtime. If we need to support downloading at server side then we need to change the runtime code.
I will send the patch for runtime to support server side download CSV file.

Thanks,
Neel Patel

On Fri, Jul 15, 2016 at 3:05 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

This seems to break downloads in the runtime. It works in Safari and Chrome, but in the runtime the suggested filename is "6980287?query=SELECT+*+FROM+pem.probe_column%0AORDER+BY+id%0AASC+&filename=probe_column.csv", and after changing that and hitting OK, the "Downloading file" dialogue is shown indefinitely.

On Wed, Jul 13, 2016 at 1:16 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi,

PFA rebased patch for RM1405

--
Harshal Dhumal
Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Wed, Jul 13, 2016 at 5:15 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Yes sure

--
Harshal Dhumal
Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Wed, Jul 13, 2016 at 5:10 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

Can you rebase this please?

Thanks.

On Mon, Jul 11, 2016 at 9:16 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi,

PFA patch for RM1405. Also to allow download in runtime we will still need patch sent by Neel.

Changes: To download query result to CSV directly from server and not to use download attr. of anchor tag (<a>) as it's not support by all of major browsers (e.g. Safari).
Also it's not feasible to load data in html to download if result set of query is very huge (in GBs).

--
Harshal Dhumal
Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Wed, Jun 29, 2016 at 4:53 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

On Wed, Jun 29, 2016 at 3:52 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Yes, It will not work in runtime as well but I think Neel is working for fix in run time for this issue, We might able to fix it in run time but issue persists in Safari unless they add support in browser itself.

https://webkit.org/status/#feature-download-attribute

> On 29-Jun-2016, at 3:40 pm, Dave Page <dpage@pgadmin.org> wrote:
>
> On Tue, Jun 28, 2016 at 10:33 AM, Murtuza Zabuawala
> <murtuza.zabuawala@enterprisedb.com> wrote:
>> Yes Dave, I agree that downloading files has been supported in browsers since long .
>>
>> But in general we send request & then receives files from web server but in our case we are fetching our data from Backbone models & then converting it to CSV format for downloading as a file at client side in browser itself.
>
> If Safari doesn't support client-side saving of files, then I have to
> wonder if our runtime will either - both are webkit based.
>
> So I guess the next question to ask is; why don't we just generate the
> CSV on the server side?
>

@Akshay,
Can you please suggest on above?

As we already have complete data in backgrid's full collection, so I have used it instead of fetching it again.

> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

--
Akshay Joshi
Principal Software Engineer

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: PATCH: Fix the issue for saving query output as CSV

From

Dave Page

Date:

18 July 2016, 14:30:21

Thanks, applied with minor changes to use the home dir as the default save location, and to store the save location as a persistent setting.

On Mon, Jul 18, 2016 at 1:27 PM, Neel Patel <neel.patel@enterprisedb.com> wrote:

Hi,

Please find attached patch file to support server side download in runtime application.

NOTE: Before applying this patch, use above harshal's patch.

Thanks,
Neel Patel

On Mon, Jul 18, 2016 at 5:31 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi,

PFA rebased patch RM1405 (version 4)

Neel will be sending patch for QT issue for same functionality.

--
Harshal Dhumal
Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Mon, Jul 18, 2016 at 4:02 PM, Dave Page <dpage@pgadmin.org> wrote:
Perfect, thanks!

On Mon, Jul 18, 2016 at 11:24 AM, Neel Patel <neel.patel@enterprisedb.com> wrote:
Yes. I am just testing with different OS. I will send it next 1-2 hour.

Is it fine ?

Thanks,
Neel Patel

On Mon, Jul 18, 2016 at 3:53 PM, Dave Page <dpage@pgadmin.org> wrote:
Any chance of getting that in the next couple of hours so I can get it into beta 3?

On Mon, Jul 18, 2016 at 11:18 AM, Dave Page <dpage@pgadmin.org> wrote:
Thanks!

On Mon, Jul 18, 2016 at 10:42 AM, Neel Patel <neel.patel@enterprisedb.com> wrote:
Hi Dave,

Yes, it will break in runtime. If we need to support downloading at server side then we need to change the runtime code.
I will send the patch for runtime to support server side download CSV file.

Thanks,
Neel Patel

On Fri, Jul 15, 2016 at 3:05 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

This seems to break downloads in the runtime. It works in Safari and Chrome, but in the runtime the suggested filename is "6980287?query=SELECT+*+FROM+pem.probe_column%0AORDER+BY+id%0AASC+&filename=probe_column.csv", and after changing that and hitting OK, the "Downloading file" dialogue is shown indefinitely.

On Wed, Jul 13, 2016 at 1:16 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi,

PFA rebased patch for RM1405

--
Harshal Dhumal
Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Wed, Jul 13, 2016 at 5:15 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Yes sure

--
Harshal Dhumal
Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Wed, Jul 13, 2016 at 5:10 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

Can you rebase this please?

Thanks.

On Mon, Jul 11, 2016 at 9:16 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi,

PFA patch for RM1405. Also to allow download in runtime we will still need patch sent by Neel.

Changes: To download query result to CSV directly from server and not to use download attr. of anchor tag (<a>) as it's not support by all of major browsers (e.g. Safari).
Also it's not feasible to load data in html to download if result set of query is very huge (in GBs).

--
Harshal Dhumal
Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Wed, Jun 29, 2016 at 4:53 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

On Wed, Jun 29, 2016 at 3:52 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Yes, It will not work in runtime as well but I think Neel is working for fix in run time for this issue, We might able to fix it in run time but issue persists in Safari unless they add support in browser itself.

https://webkit.org/status/#feature-download-attribute

> On 29-Jun-2016, at 3:40 pm, Dave Page <dpage@pgadmin.org> wrote:
>
> On Tue, Jun 28, 2016 at 10:33 AM, Murtuza Zabuawala
> <murtuza.zabuawala@enterprisedb.com> wrote:
>> Yes Dave, I agree that downloading files has been supported in browsers since long .
>>
>> But in general we send request & then receives files from web server but in our case we are fetching our data from Backbone models & then converting it to CSV format for downloading as a file at client side in browser itself.
>
> If Safari doesn't support client-side saving of files, then I have to
> wonder if our runtime will either - both are webkit based.
>
> So I guess the next question to ask is; why don't we just generate the
> CSV on the server side?
>

@Akshay,
Can you please suggest on above?

As we already have complete data in backgrid's full collection, so I have used it instead of fetching it again.

> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

--
Akshay Joshi
Principal Software Engineer

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company