Thread: Fixed RM #1209 Trigger issues through right click
Hi All
--
While fixing RM #1209 I have found following of issues, that I have fixed as part of RM #1209
- Trigger function is not displayed in the combo box for edit mode.
- Change the font of the "fieldset > legend" from 16px to 14px in overrides.css, as it doesn't looks good.
- When user set constraint trigger to "Yes" then Fires should be set to "AFTER", which is fixed.
- Code tab is always disabled and empty. User won't be able to see/update the code for PPAS when Trigger function is "Inline EDB SPL". This issue is mentioned in the RM #1209.
--
Akshay Joshi
Principal Software Engineer
Phone: +91 20-3058-9517
Mobile: +91 976-788-8246
Mobile: +91 976-788-8246
Attachment
Hi Murtuza,
Can you please review it?
On Tue, Aug 23, 2016 at 12:38 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi AllWhile fixing RM #1209 I have found following of issues, that I have fixed as part of RM #1209Attached is the patch file, please review it and let me know the review comments (if any)
- Trigger function is not displayed in the combo box for edit mode.
- Change the font of the "fieldset > legend" from 16px to 14px in overrides.css, as it doesn't looks good.
- When user set constraint trigger to "Yes" then Fires should be set to "AFTER", which is fixed.
- Code tab is always disabled and empty. User won't be able to see/update the code for PPAS when Trigger function is "Inline EDB SPL". This issue is mentioned in the RM #1209.
--Akshay JoshiPrincipal Software EngineerPhone: +91 20-3058-9517
Mobile: +91 976-788-8246
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
Sure.
--
Regards,
On Wed, Aug 24, 2016 at 10:15 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Murtuza,Can you please review it?On Tue, Aug 23, 2016 at 12:38 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote: Hi AllWhile fixing RM #1209 I have found following of issues, that I have fixed as part of RM #1209Attached is the patch file, please review it and let me know the review comments (if any)
- Trigger function is not displayed in the combo box for edit mode.
- Change the font of the "fieldset > legend" from 16px to 14px in overrides.css, as it doesn't looks good.
- When user set constraint trigger to "Yes" then Fires should be set to "AFTER", which is fixed.
- Code tab is always disabled and empty. User won't be able to see/update the code for PPAS when Trigger function is "Inline EDB SPL". This issue is mentioned in the RM #1209.
--Akshay JoshiPrincipal Software EngineerPhone: +91 20-3058-9517
Mobile: +91 976-788-8246
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
Hi Akshay,
Please address below minor issues & rest of the functionality is working.
1) In case of EPAS when user updates only code definition comment is not updated along with it for from old trigger.
2) Resize the window size so that event labels in fieldset can render properly.
Refer: server_groups.js for custom dialog size (width: '650px' should work)
Thanks,
Murtuza
--
Regards,
On Tue, Aug 23, 2016 at 12:38 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi AllWhile fixing RM #1209 I have found following of issues, that I have fixed as part of RM #1209Attached is the patch file, please review it and let me know the review comments (if any)
- Trigger function is not displayed in the combo box for edit mode.
- Change the font of the "fieldset > legend" from 16px to 14px in overrides.css, as it doesn't looks good.
- When user set constraint trigger to "Yes" then Fires should be set to "AFTER", which is fixed.
- Code tab is always disabled and empty. User won't be able to see/update the code for PPAS when Trigger function is "Inline EDB SPL". This issue is mentioned in the RM #1209.
--Akshay JoshiPrincipal Software EngineerPhone: +91 20-3058-9517
Mobile: +91 976-788-8246
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers