Postgres Pro
Downloads
Home   >   mailing lists

Thread: pgsql/src/backend/commands (dbcommands.c)

pgsql/src/backend/commands (dbcommands.c)

From
tgl@postgresql.org
Date:
  Date: Tuesday, November 14, 2000 @ 13:37:41
Author: tgl

Update of /home/projects/pgsql/cvsroot/pgsql/src/backend/commands
     from hub.org:/home/projects/pgsql/tmp/cvs-serv58825/src/backend/commands

Modified Files:
    dbcommands.c

-----------------------------  Log Message  -----------------------------

Extend CREATE DATABASE to allow selection of a template database to be
cloned, rather than always cloning template1.  Modify initdb to generate
two identical databases rather than one, template0 and template1.
Connections to template0 are disallowed, so that it will always remain
in its virgin as-initdb'd state.  pg_dumpall now dumps databases with
restore commands that say CREATE DATABASE foo WITH TEMPLATE = template0.
This allows proper behavior when there is user-added data in template1.
initdb forced!

Re: pgsql/src/backend/commands (dbcommands.c)

From
Hiroshi Inoue
Date:
tgl@postgresql.org wrote:
>
>   Date: Tuesday, November 14, 2000 @ 13:37:41
> Author: tgl
>
> Update of /home/projects/pgsql/cvsroot/pgsql/src/backend/commands
>      from hub.org:/home/projects/pgsql/tmp/cvs-serv58825/src/backend/commands
>
> Modified Files:
>         dbcommands.c
>
> -----------------------------  Log Message  -----------------------------
>
> Extend CREATE DATABASE to allow selection of a template database to be
> cloned, rather than always cloning template1.  Modify initdb to generate
> two identical databases rather than one, template0 and template1.
> Connections to template0 are disallowed, so that it will always remain
> in its virgin as-initdb'd state.  pg_dumpall now dumps databases with
> restore commands that say CREATE DATABASE foo WITH TEMPLATE = template0.
> This allows proper behavior when there is user-added data in template1.
> initdb forced!

BufferSync() after heap_insert() seems to be lost.
Connection to a database calls GetRawDatabaseinfo()
which doesn't look at shared buffer pool at all.
Connection to a database immediately after the database
was created fails under WAL e.g. in regression test.

Regards.
Hiroshi Inoue

Re: pgsql/src/backend/commands (dbcommands.c)

From
Tom Lane
Date:
Hiroshi Inoue <Inoue@tpf.co.jp> writes:
> BufferSync() after heap_insert() seems to be lost.
> Connection to a database calls GetRawDatabaseinfo()
> which doesn't look at shared buffer pool at all.
> Connection to a database immediately after the database
> was created fails under WAL e.g. in regression test.

Hmm, perhaps I misunderstood what that was for.  I moved it up to
before the system('cp -r') operation in hopes of ensuring that the
source database was up-to-date.  But maybe we need another one at
the bottom.

            regards, tom lane