Thread: pgsql-server/ oc/src/sgml/ref/cluster.sgml rc/ ...
pgsql-server/ oc/src/sgml/ref/cluster.sgml rc/ ...
From
momjian@postgresql.org (Bruce Momjian - CVS)
Date:
CVSROOT: /cvsroot
Module name: pgsql-server
Changes by: momjian@postgresql.org 02/11/14 22:09:39
Modified files:
doc/src/sgml/ref: cluster.sgml
src/backend/commands: cluster.c
src/backend/parser: gram.y
src/backend/tcop: utility.c
src/include/commands: cluster.h
src/include/nodes: parsenodes.h
src/test/regress/expected: cluster.out
src/test/regress/sql: cluster.sql
Log message:
New version attached. The following is implemented:
- CLUSTER ALL clusters all the tables that have some index with
indisclustered set and the calling user owns.
- CLUSTER tablename clusters the named table, using the index with
indisclustered set. If no index has the bit set, throws elog(ERROR).
- The multi-relation version (CLUSTER ALL) uses a multitransaction
approach, similar to what VACUUM does.
Alvaro Herrera
Hey Bruce, I'm not certain, but didn't Tom object to this patch as it made CLUSER a non-transactional command? Chris > -----Original Message----- > From: pgsql-committers-owner@postgresql.org > [mailto:pgsql-committers-owner@postgresql.org]On Behalf Of Bruce Momjian > - CVS > Sent: Friday, 15 November 2002 11:10 AM > To: pgsql-committers@postgresql.org > Subject: [COMMITTERS] pgsql-server/ oc/src/sgml/ref/cluster.sgml rc/ ... > > > CVSROOT: /cvsroot > Module name: pgsql-server > Changes by: momjian@postgresql.org 02/11/14 22:09:39 > > Modified files: > doc/src/sgml/ref: cluster.sgml > src/backend/commands: cluster.c > src/backend/parser: gram.y > src/backend/tcop: utility.c > src/include/commands: cluster.h > src/include/nodes: parsenodes.h > src/test/regress/expected: cluster.out > src/test/regress/sql: cluster.sql > > Log message: > New version attached. The following is implemented: > > - CLUSTER ALL clusters all the tables that have some index with > indisclustered set and the calling user owns. > - CLUSTER tablename clusters the named table, using the index with > indisclustered set. If no index has the bit set, throws > elog(ERROR). > - The multi-relation version (CLUSTER ALL) uses a multitransaction > approach, similar to what VACUUM does. > > Alvaro Herrera > > > ---------------------------(end of broadcast)--------------------------- > TIP 6: Have you searched our list archives? > > http://archives.postgresql.org >
It is my understanding that this was an improved version that addressed Tom's comments. In fact, I see in his comments: > > - The multi-relation version (CLUSTER ALL) uses a multitransaction > > approach, similar to what VACUUM does. so I think this is the improved version. --------------------------------------------------------------------------- Christopher Kings-Lynne wrote: > Hey Bruce, > > I'm not certain, but didn't Tom object to this patch as it made CLUSER a > non-transactional command? > > Chris > > > -----Original Message----- > > From: pgsql-committers-owner@postgresql.org > > [mailto:pgsql-committers-owner@postgresql.org]On Behalf Of Bruce Momjian > > - CVS > > Sent: Friday, 15 November 2002 11:10 AM > > To: pgsql-committers@postgresql.org > > Subject: [COMMITTERS] pgsql-server/ oc/src/sgml/ref/cluster.sgml rc/ ... > > > > > > CVSROOT: /cvsroot > > Module name: pgsql-server > > Changes by: momjian@postgresql.org 02/11/14 22:09:39 > > > > Modified files: > > doc/src/sgml/ref: cluster.sgml > > src/backend/commands: cluster.c > > src/backend/parser: gram.y > > src/backend/tcop: utility.c > > src/include/commands: cluster.h > > src/include/nodes: parsenodes.h > > src/test/regress/expected: cluster.out > > src/test/regress/sql: cluster.sql > > > > Log message: > > New version attached. The following is implemented: > > > > - CLUSTER ALL clusters all the tables that have some index with > > indisclustered set and the calling user owns. > > - CLUSTER tablename clusters the named table, using the index with > > indisclustered set. If no index has the bit set, throws > > elog(ERROR). > > - The multi-relation version (CLUSTER ALL) uses a multitransaction > > approach, similar to what VACUUM does. > > > > Alvaro Herrera > > > > > > ---------------------------(end of broadcast)--------------------------- > > TIP 6: Have you searched our list archives? > > > > http://archives.postgresql.org > > > > > ---------------------------(end of broadcast)--------------------------- > TIP 4: Don't 'kill -9' the postmaster > -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania 19073
On Fri, Nov 15, 2002 at 11:17:08AM +0800, Christopher Kings-Lynne wrote: > Hey Bruce, > > I'm not certain, but didn't Tom object to this patch as it made CLUSER a > non-transactional command? I rewrote it. Only CLUSTER ALL is non-transactional. -- Alvaro Herrera (<alvherre[a]dcc.uchile.cl>) "You knock on that door or the sun will be shining on places inside you that the sun doesn't usually shine" (en Death: "The High Cost of Living")
Since tom originally objected, though, shouldn't you have requested some sort of comment from him *before* applying? On Thu, 14 Nov 2002, Bruce Momjian wrote: > > It is my understanding that this was an improved version that addressed > Tom's comments. > > In fact, I see in his comments: > > > > - The multi-relation version (CLUSTER ALL) uses a multitransaction > > > approach, similar to what VACUUM does. > > so I think this is the improved version. > > --------------------------------------------------------------------------- > > Christopher Kings-Lynne wrote: > > Hey Bruce, > > > > I'm not certain, but didn't Tom object to this patch as it made CLUSER a > > non-transactional command? > > > > Chris > > > > > -----Original Message----- > > > From: pgsql-committers-owner@postgresql.org > > > [mailto:pgsql-committers-owner@postgresql.org]On Behalf Of Bruce Momjian > > > - CVS > > > Sent: Friday, 15 November 2002 11:10 AM > > > To: pgsql-committers@postgresql.org > > > Subject: [COMMITTERS] pgsql-server/ oc/src/sgml/ref/cluster.sgml rc/ ... > > > > > > > > > CVSROOT: /cvsroot > > > Module name: pgsql-server > > > Changes by: momjian@postgresql.org 02/11/14 22:09:39 > > > > > > Modified files: > > > doc/src/sgml/ref: cluster.sgml > > > src/backend/commands: cluster.c > > > src/backend/parser: gram.y > > > src/backend/tcop: utility.c > > > src/include/commands: cluster.h > > > src/include/nodes: parsenodes.h > > > src/test/regress/expected: cluster.out > > > src/test/regress/sql: cluster.sql > > > > > > Log message: > > > New version attached. The following is implemented: > > > > > > - CLUSTER ALL clusters all the tables that have some index with > > > indisclustered set and the calling user owns. > > > - CLUSTER tablename clusters the named table, using the index with > > > indisclustered set. If no index has the bit set, throws > > > elog(ERROR). > > > - The multi-relation version (CLUSTER ALL) uses a multitransaction > > > approach, similar to what VACUUM does. > > > > > > Alvaro Herrera > > > > > > > > > ---------------------------(end of broadcast)--------------------------- > > > TIP 6: Have you searched our list archives? > > > > > > http://archives.postgresql.org > > > > > > > > > ---------------------------(end of broadcast)--------------------------- > > TIP 4: Don't 'kill -9' the postmaster > > > > -- > Bruce Momjian | http://candle.pha.pa.us > pgman@candle.pha.pa.us | (610) 359-1001 > + If your life is a hard drive, | 13 Roberts Road > + Christ can be your backup. | Newtown Square, Pennsylvania 19073 > > ---------------------------(end of broadcast)--------------------------- > TIP 6: Have you searched our list archives? > > http://archives.postgresql.org >
He posted it, and it went in the queue after the standard delay, and was applied after another standard delay. I am not interested in getting opt-in for patch application from patch objectors. They can see the email messages flow by. --------------------------------------------------------------------------- Marc G. Fournier wrote: > > Since tom originally objected, though, shouldn't you have requested some > sort of comment from him *before* applying? > > On Thu, 14 Nov 2002, Bruce Momjian wrote: > > > > > It is my understanding that this was an improved version that addressed > > Tom's comments. > > > > In fact, I see in his comments: > > > > > > - The multi-relation version (CLUSTER ALL) uses a multitransaction > > > > approach, similar to what VACUUM does. > > > > so I think this is the improved version. > > > > --------------------------------------------------------------------------- > > > > Christopher Kings-Lynne wrote: > > > Hey Bruce, > > > > > > I'm not certain, but didn't Tom object to this patch as it made CLUSER a > > > non-transactional command? > > > > > > Chris > > > > > > > -----Original Message----- > > > > From: pgsql-committers-owner@postgresql.org > > > > [mailto:pgsql-committers-owner@postgresql.org]On Behalf Of Bruce Momjian > > > > - CVS > > > > Sent: Friday, 15 November 2002 11:10 AM > > > > To: pgsql-committers@postgresql.org > > > > Subject: [COMMITTERS] pgsql-server/ oc/src/sgml/ref/cluster.sgml rc/ ... > > > > > > > > > > > > CVSROOT: /cvsroot > > > > Module name: pgsql-server > > > > Changes by: momjian@postgresql.org 02/11/14 22:09:39 > > > > > > > > Modified files: > > > > doc/src/sgml/ref: cluster.sgml > > > > src/backend/commands: cluster.c > > > > src/backend/parser: gram.y > > > > src/backend/tcop: utility.c > > > > src/include/commands: cluster.h > > > > src/include/nodes: parsenodes.h > > > > src/test/regress/expected: cluster.out > > > > src/test/regress/sql: cluster.sql > > > > > > > > Log message: > > > > New version attached. The following is implemented: > > > > > > > > - CLUSTER ALL clusters all the tables that have some index with > > > > indisclustered set and the calling user owns. > > > > - CLUSTER tablename clusters the named table, using the index with > > > > indisclustered set. If no index has the bit set, throws > > > > elog(ERROR). > > > > - The multi-relation version (CLUSTER ALL) uses a multitransaction > > > > approach, similar to what VACUUM does. > > > > > > > > Alvaro Herrera > > > > > > > > > > > > ---------------------------(end of broadcast)--------------------------- > > > > TIP 6: Have you searched our list archives? > > > > > > > > http://archives.postgresql.org > > > > > > > > > > > > > ---------------------------(end of broadcast)--------------------------- > > > TIP 4: Don't 'kill -9' the postmaster > > > > > > > -- > > Bruce Momjian | http://candle.pha.pa.us > > pgman@candle.pha.pa.us | (610) 359-1001 > > + If your life is a hard drive, | 13 Roberts Road > > + Christ can be your backup. | Newtown Square, Pennsylvania 19073 > > > > ---------------------------(end of broadcast)--------------------------- > > TIP 6: Have you searched our list archives? > > > > http://archives.postgresql.org > > > > > ---------------------------(end of broadcast)--------------------------- > TIP 4: Don't 'kill -9' the postmaster > -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania 19073