Thread: pgsql: Correct some code in pg_restore when reading the header of a tar

pgsql: Correct some code in pg_restore when reading the header of a tar

From

neilc@svr1.postgresql.org (Neil Conway)

Date:

21 June 2005, 23:02:22

Log Message:
-----------
Correct some code in pg_restore when reading the header of a tar archive:

(1) The code doesn't initialize `sum', so the initial "does the checksum
    match?" test is wrong.

(2) The loop that is intended to check for a "null block" just checks
    the first byte of the tar block 512 times, rather than each of the
    512 bytes one time (!), which I'm guessing was the intent.

It was only through sheer luck that this worked in the first place.

Per Coverity static analysis performed by EnterpriseDB.

Tags:
----
REL8_0_STABLE

Modified Files:
--------------
    pgsql/src/bin/pg_dump:
        pg_backup_tar.c (r1.46.4.1 -> r1.46.4.2)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/bin/pg_dump/pg_backup_tar.c.diff?r1=1.46.4.1&r2=1.46.4.2)