Thread: pgsql: Fix old pg_dump oversight: default values for domains really need

pgsql: Fix old pg_dump oversight: default values for domains really need

From

tgl@postgresql.org (Tom Lane)

Date:

21 February 2006, 14:01:46

Log Message:
-----------
Fix old pg_dump oversight: default values for domains really need to be dumped
by decompiling the typdefaultbin expression, not just printing the typdefault
text which may be out-of-date or assume the wrong schema search path.  (It's
the same hazard as for adbin vs adsrc in column defaults.)  The catalogs.sgml
spec for pg_type implies that the correct procedure is to look to
typdefaultbin first and consider typdefault only if typdefaultbin is NULL.
I made dumping of both domains and base types do that, even though in the
current backend code typdefaultbin is always correct for domains and
typdefault for base types --- might as well try to future-proof it a little.
Per bug report from Alexander Galler.

Tags:
----
REL8_1_STABLE

Modified Files:
--------------
    pgsql/src/bin/pg_dump:
        pg_dump.c (r1.422.2.2 -> r1.422.2.3)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/bin/pg_dump/pg_dump.c.diff?r1=1.422.2.2&r2=1.422.2.3)