Thread: pgsql: Add new contrib function pgrowlocks.

Log Message:
-----------
Add new contrib function pgrowlocks. See README.pgrowlocks for more details.

Added Files:
-----------
    pgsql/contrib/pgrowlocks:
        Makefile (r1.1)

(http://developer.postgresql.org/cvsweb.cgi/pgsql/contrib/pgrowlocks/Makefile?rev=1.1&content-type=text/x-cvsweb-markup)
        README.pgrowlocks (r1.1)

(http://developer.postgresql.org/cvsweb.cgi/pgsql/contrib/pgrowlocks/README.pgrowlocks?rev=1.1&content-type=text/x-cvsweb-markup)
        README.pgrowlocks.euc_jp (r1.1)

(http://developer.postgresql.org/cvsweb.cgi/pgsql/contrib/pgrowlocks/README.pgrowlocks.euc_jp?rev=1.1&content-type=text/x-cvsweb-markup)
        pgrowlocks.c (r1.1)

(http://developer.postgresql.org/cvsweb.cgi/pgsql/contrib/pgrowlocks/pgrowlocks.c?rev=1.1&content-type=text/x-cvsweb-markup)
        pgrowlocks.sql.in (r1.1)

(http://developer.postgresql.org/cvsweb.cgi/pgsql/contrib/pgrowlocks/pgrowlocks.sql.in?rev=1.1&content-type=text/x-cvsweb-markup)

On Sat, Apr 22, 2006 at 10:12:58PM -0300, Tatsuo Ishii wrote:
> Log Message:
> -----------
> Add new contrib function pgrowlocks. See README.pgrowlocks for more details.

Calling this function results in SIGBUS on Solaris 9/sparc.

test=> CREATE TABLE foo (id integer);
CREATE TABLE
test=> SELECT * FROM pgrowlocks('foo');
server closed the connection unexpectedly

% gdb bin/postgres data/core
[...]
Program terminated with signal 10, Bus error.
[...]
(gdb) bt
#0  UnlockRelation (relation=0x7f7f7f7f, lockmode=1) at lmgr.c:126
#1  0x0005aeb8 in relation_close (relation=0x7f7f7f7f, lockmode=1) at heapam.c:786
#2  0xfee90d4c in pgrowlocks (fcinfo=0xffbfe238) at pgrowlocks.c:225
#3  0x00115830 in ExecMakeTableFunctionResult (funcexpr=0x3e0068, econtext=0x3df958, expectedDesc=0x3dfc10,
returnDesc=0xffbfe4b4)at execQual.c:1305 
#4  0x00125160 in FunctionNext (node=0x3df8c8) at nodeFunctionscan.c:71
#5  0x001199d4 in ExecScan (node=0x3df8c8, accessMtd=0x1250f4 <FunctionNext>) at execScan.c:68
#6  0x00113a30 in ExecProcNode (node=0x3df8c8) at execProcnode.c:366
#7  0x00112928 in ExecutorRun (queryDesc=0x3df8c8, direction=ForwardScanDirection, count=0) at execMain.c:1144
#8  0x001acacc in PortalRunSelect (portal=0x3dd2f8, forward=1 '\001', count=0, dest=0x3d1670) at pquery.c:804
#9  0x001ad314 in PortalRun (portal=0x3dd2f8, count=2147483647, dest=0x3d1670, altdest=0x3d1670,
completionTag=0xffbfe860"") at pquery.c:621 
#10 0x001a8414 in exec_simple_query (query_string=0x3d0e40 "SELECT * FROM pgrowlocks('foo');") at postgres.c:1017
#11 0x001a9dc4 in PostgresMain (argc=4, argv=0x382510, username=0x3824e0 "mfuhr") at postgres.c:3250
#12 0x0017c364 in ServerLoop () at postmaster.c:2915
#13 0x0017e4f4 in PostmasterMain (argc=0, argv=0x357ac0) at postmaster.c:980
#14 0x00135880 in main (argc=3, argv=0x357ac0) at main.c:254

--
Michael Fuhr

> On Sat, Apr 22, 2006 at 10:12:58PM -0300, Tatsuo Ishii wrote:
> > Log Message:
> > -----------
> > Add new contrib function pgrowlocks. See README.pgrowlocks for more details.
>
> Calling this function results in SIGBUS on Solaris 9/sparc.
>
> test=> CREATE TABLE foo (id integer);
> CREATE TABLE
> test=> SELECT * FROM pgrowlocks('foo');
> server closed the connection unexpectedly
>
> % gdb bin/postgres data/core
> [...]
> Program terminated with signal 10, Bus error.
[snip]

Thanks for the report. I have committed fix for this. Can you try it
out?
--
Tatsuo Ishii
SRA OSS, Inc. Japan

On Tue, Apr 25, 2006 at 09:44:25AM +0900, Tatsuo Ishii wrote:
> > test=> CREATE TABLE foo (id integer);
> > CREATE TABLE
> > test=> SELECT * FROM pgrowlocks('foo');
> > server closed the connection unexpectedly
> >
> > % gdb bin/postgres data/core
> > [...]
> > Program terminated with signal 10, Bus error.
> [snip]
>
> Thanks for the report. I have committed fix for this. Can you try it
> out?

No crashes so far; I'll follow up if I see any more problems.
Thanks.

--
Michael Fuhr