Thread: pgsql: Adjust script to be consistent (thanks Tom for the fix).
pgsql: Adjust script to be consistent (thanks Tom for the fix).
From
momjian@postgresql.org (Bruce Momjian)
Date:
Log Message:
-----------
Adjust script to be consistent (thanks Tom for the fix).
Modified Files:
--------------
pgsql/contrib/uuid-ossp:
uuid-ossp.sql.in (r1.4 -> r1.5)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/contrib/uuid-ossp/uuid-ossp.sql.in?r1=1.4&r2=1.5)
momjian@postgresql.org (Bruce Momjian) writes: > pgsql/contrib/uuid-ossp: > uuid-ossp.sql.in (r1.4 -> r1.5) > (http://developer.postgresql.org/cvsweb.cgi/pgsql/contrib/uuid-ossp/uuid-ossp.sql.in?r1=1.4&r2=1.5) Pray tell, why do you think it's a good idea to not have version labels in the contrib scripts? regards, tom lane
Tom Lane wrote: > momjian@postgresql.org (Bruce Momjian) writes: > > pgsql/contrib/uuid-ossp: > > uuid-ossp.sql.in (r1.4 -> r1.5) > > (http://developer.postgresql.org/cvsweb.cgi/pgsql/contrib/uuid-ossp/uuid-ossp.sql.in?r1=1.4&r2=1.5) > > Pray tell, why do you think it's a good idea to not have version labels > in the contrib scripts? If we want them, they should be in all of them. I am worried slightly that a version label will make the SET search_path harder to find, though. -- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB http://postgres.enterprisedb.com + If your life is a hard drive, Christ can be your backup. +
Bruce Momjian <bruce@momjian.us> writes:
> Tom Lane wrote:
>> Pray tell, why do you think it's a good idea to not have version labels
>> in the contrib scripts?
> If we want them, they should be in all of them.
+1 for putting the label in all of them --- these files end up "loose"
in user installations, so having a clear version identity on them seems
like a Real Good Idea.
> I am worried slightly
> that a version label will make the SET search_path harder to find, though.
The documentation already says "first command", and there is already
one comment in front of that. I don't think having two comments in
front of it will deter anyone smart enough to be installing contrib
modules into nonstandard schemas.
regards, tom lane
Tom Lane wrote: > Bruce Momjian <bruce@momjian.us> writes: > > Tom Lane wrote: > >> Pray tell, why do you think it's a good idea to not have version labels > >> in the contrib scripts? > > > If we want them, they should be in all of them. > > +1 for putting the label in all of them --- these files end up "loose" > in user installations, so having a clear version identity on them seems > like a Real Good Idea. > > > I am worried slightly > > that a version label will make the SET search_path harder to find, though. > > The documentation already says "first command", and there is already > one comment in front of that. I don't think having two comments in > front of it will deter anyone smart enough to be installing contrib > modules into nonstandard schemas. Agreed. Done. -- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB http://postgres.enterprisedb.com + If your life is a hard drive, Christ can be your backup. +