Thread: pgsql: Insert conditional SPI_push/SPI_pop calls into InputFunctionCall,

Log Message:
-----------
Insert conditional SPI_push/SPI_pop calls into InputFunctionCall,
OutputFunctionCall, and friends.  This allows SPI-using functions to invoke
datatype I/O without concern for the possibility that a SPI-using function
will be called (which could be either the I/O function itself, or a function
used in a domain check constraint).  It's a tad ugly, but not nearly as ugly
as what'd be needed to make this work via retail insertion of push/pop
operations in all the PLs.

This reverts my patch of 2007-01-30 that inserted some retail SPI_push/pop
calls into plpgsql; that approach only fixed plpgsql, and not any other PLs.
But the other PLs have the issue too, as illustrated by a recent gripe from
Christian Schr�der.

Back-patch to 8.2, which is as far back as this solution will work.  It's
also as far back as we need to worry about the domain-constraint case, since
earlier versions did not attempt to check domain constraints within datatype
input.  I'm not aware of any old I/O functions that use SPI themselves, so
this should be sufficient for a back-patch.

Tags:
----
REL8_2_STABLE

Modified Files:
--------------
    pgsql/src/backend/executor:
        spi.c (r1.165.2.5 -> r1.165.2.6)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/executor/spi.c?r1=1.165.2.5&r2=1.165.2.6)
    pgsql/src/backend/utils/fmgr:
        fmgr.c (r1.102.2.2 -> r1.102.2.3)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/fmgr/fmgr.c?r1=1.102.2.2&r2=1.102.2.3)
    pgsql/src/include/executor:
        spi.h (r1.58.2.1 -> r1.58.2.2)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/executor/spi.h?r1=1.58.2.1&r2=1.58.2.2)
    pgsql/src/pl/plpgsql/src:
        pl_exec.c (r1.180.2.6 -> r1.180.2.7)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/pl/plpgsql/src/pl_exec.c?r1=1.180.2.6&r2=1.180.2.7)