Thread: pgsql: Message style cleanup

pgsql: Message style cleanup

From
Peter Eisentraut
Date:
Message style cleanup

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/bff074b1ab0dfed7a7822dcc8942f877efa3b914

Modified Files
--------------
src/bin/pg_basebackup/pg_basebackup.c |   62 ++++++++++++++++----------------
1 files changed, 31 insertions(+), 31 deletions(-)


Re: pgsql: Message style cleanup

From
Magnus Hagander
Date:
Is this part really correct?

-       fprintf(stderr, _("%s: final receive failed: %s\n"),
+       fprintf(stderr, _("%s: final receive failed: %s"),

all other msgs have \n.. I see you removed the final dot in many of
the other messages, did you just accidentally grab one too  many?
(There are a couple of other examples of removing the \n though, so
perhaps it was  intentional? But they're all preceeding
disconnect_and_exit() so I don't see why it shouldn't be consistent?

//Magnus

On Wed, May 4, 2011 at 20:10, Peter Eisentraut <peter_e@gmx.net> wrote:
> Message style cleanup
>
> Branch
> ------
> master
>
> Details
> -------
> http://git.postgresql.org/pg/commitdiff/bff074b1ab0dfed7a7822dcc8942f877efa3b914
>
> Modified Files
> --------------
> src/bin/pg_basebackup/pg_basebackup.c |   62 ++++++++++++++++----------------
> 1 files changed, 31 insertions(+), 31 deletions(-)
>
>
> --
> Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-committers
>



--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/