Thread: pgsql: Promote the assertion that XLogBeginInsert() is not called twice

Promote the assertion that XLogBeginInsert() is not called twice into ERROR.

Seems like cheap insurance for WAL bugs. A spurious call to
XLogBeginInsert() in itself would be fairly harmless, but if there is any
data registered and the insertion is not completed/cancelled properly, there
is a risk that the data ends up in a wrong WAL record.

Per Jeff Janes's suggestion.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/a32c3ec893cafbd3a4b42c34270a80198f28f123

Modified Files
--------------
src/backend/access/transam/xloginsert.c |    4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)