Thread: pgsql: Run the C portions of guc-file.l through pgindent.
Run the C portions of guc-file.l through pgindent. Yeah, I know, pretty anal-retentive of me. But we oughta find some way to automate this for the .y and .l files. Branch ------ master Details ------- http://git.postgresql.org/pg/commitdiff/2bdc51a2946f9a66688eb705cd0cb584ebd8240a Modified Files -------------- src/backend/utils/misc/guc-file.l | 106 +++++++++++++++++++------------------ 1 file changed, 54 insertions(+), 52 deletions(-)
On Mon, Jun 29, 2015 at 9:49 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Run the C portions of guc-file.l through pgindent.
>
> Yeah, I know, pretty anal-retentive of me. But we oughta find some
> way to automate this for the .y and .l files.
.y files may be tricky and .l files less. Still one good way to test
such things would be to use something like that and see at least what
happens when doing a run (haven't tested, use at your own risk):
diff --git a/src/tools/pgindent/pgindent b/src/tools/pgindent/pgindent
index 0d3859d..3995214 100755
--- a/src/tools/pgindent/pgindent
+++ b/src/tools/pgindent/pgindent
@@ -519,6 +519,7 @@ File::Find::find(
(($dev, $ino, $mode, $nlink, $uid, $gid) = lstat($_))
&& -f _
&& /^.*\.[ch]\z/s
+ && /^.*\.(h|c|y|l)\z/s
&& push(@files, $File::Find::name);
}
},
Regards,
--
Michael
On 06/28/2015 09:24 PM, Michael Paquier wrote: > On Mon, Jun 29, 2015 at 9:49 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote: >> Run the C portions of guc-file.l through pgindent. >> >> Yeah, I know, pretty anal-retentive of me. But we oughta find some >> way to automate this for the .y and .l files. > .y files may be tricky and .l files less. Still one good way to test > such things would be to use something like that and see at least what > happens when doing a run (haven't tested, use at your own risk): > diff --git a/src/tools/pgindent/pgindent b/src/tools/pgindent/pgindent > index 0d3859d..3995214 100755 > --- a/src/tools/pgindent/pgindent > +++ b/src/tools/pgindent/pgindent > @@ -519,6 +519,7 @@ File::Find::find( > (($dev, $ino, $mode, $nlink, $uid, $gid) = lstat($_)) > && -f _ > && /^.*\.[ch]\z/s > + && /^.*\.(h|c|y|l)\z/s > && push(@files, $File::Find::name); > } > }, > > Regards, Try it and see. I would expect it to blow up badly. It should be possible to teach pgindent to extract the C portions of the files, indent them and then replace them. Of course, especially in the case of .y files, that would exclude almost all of the files in many cases. cheers andrew