Postgres Pro
Downloads
Home   >   mailing lists

Thread: vacuumdb clarification

vacuumdb clarification

From
Bruce Momjian
Date:
Here is a documentation patch I have applied to clarify that --analyze
does analyze during vacuum, not instead of vacuum.

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +
Index: doc/src/sgml/ref/vacuumdb.sgml
===================================================================
RCS file: /cvsroot/pgsql/doc/src/sgml/ref/vacuumdb.sgml,v
retrieving revision 1.44
diff -c -c -r1.44 vacuumdb.sgml
*** doc/src/sgml/ref/vacuumdb.sgml    26 Feb 2009 16:02:37 -0000    1.44
--- doc/src/sgml/ref/vacuumdb.sgml    13 Nov 2009 19:46:37 -0000
***************
*** 159,165 ****
        <term><option>--analyze</option></term>
        <listitem>
         <para>
!         Calculate statistics for use by the optimizer.
         </para>
        </listitem>
       </varlistentry>
--- 159,165 ----
        <term><option>--analyze</option></term>
        <listitem>
         <para>
!         Calculate statistics for use by the optimizer during vacuum.
         </para>
        </listitem>
       </varlistentry>

Re: vacuumdb clarification

From
Peter Eisentraut
Date:
On fre, 2009-11-13 at 14:49 -0500, Bruce Momjian wrote:
> Here is a documentation patch I have applied to clarify that --analyze
> does analyze during vacuum, not instead of vacuum.

I don't see this committed, but I would vote against it, because the
wording makes it sound like the statistics are for use by the optimizer
during vacuum.

diff -c -c -r1.44 vacuumdb.sgml
*** doc/src/sgml/ref/vacuumdb.sgml      26 Feb 2009 16:02:37 -0000
1.44
--- doc/src/sgml/ref/vacuumdb.sgml      13 Nov 2009 19:46:37 -0000
***************
*** 159,165 ****
        <term><option>--analyze</option></term>
        <listitem>
         <para>
!         Calculate statistics for use by the optimizer.
         </para>
        </listitem>
       </varlistentry>
--- 159,165 ----
        <term><option>--analyze</option></term>
        <listitem>
         <para>
!         Calculate statistics for use by the optimizer during vacuum.
         </para>
        </listitem>
       </varlistentry>

Re: vacuumdb clarification

From
Bruce Momjian
Date:
Peter Eisentraut wrote:
> On fre, 2009-11-13 at 14:49 -0500, Bruce Momjian wrote:
> > Here is a documentation patch I have applied to clarify that --analyze
> > does analyze during vacuum, not instead of vacuum.
>
> I don't see this committed, but I would vote against it, because the
> wording makes it sound like the statistics are for use by the optimizer
> during vacuum.

I agree with your analysis.  I have applied a simpler wording
improvement that just adds the word "Also".

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +
Index: doc/src/sgml/ref/vacuumdb.sgml
===================================================================
RCS file: /cvsroot/pgsql/doc/src/sgml/ref/vacuumdb.sgml,v
retrieving revision 1.44
diff -c -c -r1.44 vacuumdb.sgml
*** doc/src/sgml/ref/vacuumdb.sgml    26 Feb 2009 16:02:37 -0000    1.44
--- doc/src/sgml/ref/vacuumdb.sgml    27 Nov 2009 17:40:12 -0000
***************
*** 159,165 ****
        <term><option>--analyze</option></term>
        <listitem>
         <para>
!         Calculate statistics for use by the optimizer.
         </para>
        </listitem>
       </varlistentry>
--- 159,165 ----
        <term><option>--analyze</option></term>
        <listitem>
         <para>
!         Also calculate statistics for use by the optimizer.
         </para>
        </listitem>
       </varlistentry>