Postgres Pro
Downloads
Home   >   mailing lists

Thread: subselects

subselects

From
Bruce Momjian
Date:
OK, I have added code to allow the SubLinks make it to the optimizer.

I implemented ParseState->parentParseState, but not parentQuery, because
the parentParseState is much more valuable to me, and Vadim thought it
might be useful, but was not positive.  Also, keeping that parentQuery
pointer valid through rewrite may be difficult, so I dropped it.
ParseState is only valid in the parser.

I have not done:

    correlated subquery column references
    added Var->sublevels_up
    gotten this to work in the rewrite system
    have not added full CopyNode support

I will address these in the next few days.

--
Bruce Momjian
maillist@candle.pha.pa.us

Re: subselects

From
"Vadim B. Mikheev"
Date:
Bruce Momjian wrote:
>
> OK, I have added code to allow the SubLinks make it to the optimizer.
>
> I implemented ParseState->parentParseState, but not parentQuery, because
> the parentParseState is much more valuable to me, and Vadim thought it
> might be useful, but was not positive.  Also, keeping that parentQuery
> pointer valid through rewrite may be difficult, so I dropped it.
> ParseState is only valid in the parser.
>
> I have not done:
>
>         correlated subquery column references
>         added Var->sublevels_up
>         gotten this to work in the rewrite system
>         have not added full CopyNode support
>
> I will address these in the next few days.

Nice! I'm starting with non-correlated subqueries...

Vadim

Re: [HACKERS] Re: subselects

From
Bruce Momjian
Date:
> > I have not done:
> >
> >         correlated subquery column references
> >         added Var->sublevels_up
> >         gotten this to work in the rewrite system
> >         have not added full CopyNode support
> >
> > I will address these in the next few days.
>

OK, had some bugs, but now it works.  Ran postmaster with full debug,
and saw proper values in SubLink structure.  In fact, the optimizer
seems to pass this through fine, only to error out in the executor with
'unknown node.'

--
Bruce Momjian
maillist@candle.pha.pa.us

Re: [HACKERS] Re: subselects

From
Bruce Momjian
Date:
> > I have not done:
> >
> >         correlated subquery column references
> >         added Var->sublevels_up
> >         gotten this to work in the rewrite system

This item is done now:
> >         have not added full CopyNode support

--
Bruce Momjian
maillist@candle.pha.pa.us

Re: [HACKERS] Re: subselects

From
Bruce Momjian
Date:
> > I have not done:
> >
> >         correlated subquery column references
> >         added Var->sublevels_up
> >         gotten this to work in the rewrite system
> >         have not added full CopyNode support
> >

OK, these are all done now.

--
Bruce Momjian
maillist@candle.pha.pa.us