Thread: Re: [PATCHES] [patch 0/9] annual pgcrypto update

On Thu, 2006-07-13 at 00:50 -0400, Tom Lane wrote:
> This has broken two out of the four buildfarm members that reported
> in the last half hour :-(  I think kudu does not like // comments,
> not sure what kookaburra is on about.

BTW, you've switched your animal names :) I fixed the C++-style comment.

Marko, can you take a look at what is causing this regression test
failure? The failing machine is kudu:

http://www.pgbuildfarm.org/cgi-bin/show_history.pl?nm=kudu&br=HEAD

The regression.diffs are:

*** ./expected/pgp-pubkey-decrypt.out    Wed Jul 12 21:30:59 2006
--- ./results/pgp-pubkey-decrypt.out    Wed Jul 12 21:39:15 2006
***************
*** 544,555 ****
  -- password-protected secret key, wrong password
  select pgp_pub_decrypt(dearmor(data), dearmor(seckey), 'foo')
  from keytbl, encdata where keytbl.id=5 and encdata.id=1;
! ERROR:  Corrupt data
  -- password-protected secret key, right password
  select pgp_pub_decrypt(dearmor(data), dearmor(seckey), 'parool')
  from keytbl, encdata where keytbl.id=5 and encdata.id=1;
!  pgp_pub_decrypt
! -----------------
!  Secret msg
! (1 row)
!
--- 544,551 ----
  -- password-protected secret key, wrong password
  select pgp_pub_decrypt(dearmor(data), dearmor(seckey), 'foo')
  from keytbl, encdata where keytbl.id=5 and encdata.id=1;
! ERROR:  Unsupported cipher algorithm
  -- password-protected secret key, right password
  select pgp_pub_decrypt(dearmor(data), dearmor(seckey), 'parool')
  from keytbl, encdata where keytbl.id=5 and encdata.id=1;
! ERROR:  Unsupported cipher algorithm

-Neil

On 7/13/06, Neil Conway <neilc@samurai.com> wrote:
> Marko, can you take a look at what is causing this regression test
> failure? The failing machine is kudu:

Seems you have skipped the CAST5 patch.  Could you recheck?

--
marko

"Marko Kreen" <markokr@gmail.com> writes:
> On 7/13/06, Neil Conway <neilc@samurai.com> wrote:
>> Marko, can you take a look at what is causing this regression test
>> failure? The failing machine is kudu:

> Seems you have skipped the CAST5 patch.  Could you recheck?

Applied, thanks.  What I now see is that pgp-pubkey-decrypt passes on
a 32-bit machine but dumps core on a 64-bit machine, with SIGSEGV here:

#0  0x00002aaaac8b82ba in mp_int_div (a=Variable "a" is not available.
) at imath.c:3068
3068          q.digits[qpos++] = (mp_digit) qdigit;
(gdb) bt
#0  0x00002aaaac8b82ba in mp_int_div (a=Variable "a" is not available.
) at imath.c:3068
#1  0x00002aaaac8b9531 in mp_int_exptmod (a=0x970a28, b=0x978530, m=0x9780e0,   c=0x978980) at imath.c:1234
#2  0x00002aaaac8b4ef3 in pgp_elgamal_decrypt (pk=Variable "pk" is not available.
) at pgp-mpi-internal.c:225
#3  0x00002aaaac8be2b9 in pgp_parse_pubenc_sesskey (ctx=0x972848,   pkt=0x977328) at pgp-pubdec.c:116
#4  0x00002aaaac8bca0b in pgp_decrypt (ctx=0x972848, msrc=Variable "msrc" is not available.
)   at pgp-decrypt.c:1126
#5  0x00002aaaac8c0a73 in decrypt_internal (is_pubenc=0, need_text=1,   data=0x9772d0, key=0x976ab8, keypsw=0x0,
args=Variable"args" is not available.
 

Any thoughts about the cause?
        regards, tom lane

I wrote:
> Applied, thanks.  What I now see is that pgp-pubkey-decrypt passes on
> a 32-bit machine but dumps core on a 64-bit machine, with SIGSEGV here:

Addendum: seems it only fails without openssl.
        regards, tom lane

On 7/14/06, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> I wrote:
> > Applied, thanks.  What I now see is that pgp-pubkey-decrypt passes on
> > a 32-bit machine but dumps core on a 64-bit machine, with SIGSEGV here:
>
> Addendum: seems it only fails without openssl.

iMath's protability checks failed.  Attached patch drops them
and expects postgres.h to give correct types.

Also enable asserts to fail earlier.

--
marko

"Marko Kreen" <markokr@gmail.com> writes:
> iMath's protability checks failed.  Attached patch drops them
> and expects postgres.h to give correct types.

> Also enable asserts to fail earlier.

Applied, thanks.  Looks like this should fix current buildfarm
failure on "bear".
        regards, tom lane