Thread: Re: [COMMITTERS] pgsql: Add sample text search dictionary templates and parsers, to

Andrew Dunstan <andrew@dunslane.net> writes:
> Looks like dict-xsyn needs some windows install help for the rules file.

Ah, I was afraid of that :-(.  The bespoke rule for installing that file
looked like trouble but I forgot about it while looking at the rest of
the code.

It doesn't seem like teaching Mkvcbuild.pm about this specific file
would be a real good plan.  Can we get the DATA macro to handle it
somehow?  It's not going into the toplevel SHAREDIR --- will a relative
path work?

            regards, tom lane

On Mon, Oct 15, 2007 at 07:17:12PM -0400, Tom Lane wrote:
> Andrew Dunstan <andrew@dunslane.net> writes:
> > Looks like dict-xsyn needs some windows install help for the rules file.
>
> Ah, I was afraid of that :-(.  The bespoke rule for installing that file
> looked like trouble but I forgot about it while looking at the rest of
> the code.
>
> It doesn't seem like teaching Mkvcbuild.pm about this specific file
> would be a real good plan.  Can we get the DATA macro to handle it
> somehow?  It's not going into the toplevel SHAREDIR --- will a relative
> path work?

The msvc Install.pm file (not Mkvcbuild in this case) will put it in
/share/contrib/, and currently doesn't support subdirs. But it can bemade
to support those if needed, I guess. No idea if that'll work on non-msvc
builds.

Do we expect there might be more like this? We could easily add a rule
to Install.pm to know about DICTFILES rules in addition to DATA rules.. (In
CopyContribFiles in Install.pm)

//Magnus

Magnus Hagander <magnus@hagander.net> writes:
> Do we expect there might be more like this? We could easily add a rule
> to Install.pm to know about DICTFILES rules in addition to DATA
> rules..

Yeah, after sleeping on it I think we need a general-purpose solution.
There are likely to be more not fewer tsearch-related contrib modules
in future; and even if you don't believe that, people will certainly
want to use the PGXS infrastructure to build add-on dictionaries.
So we should provide a DATA-like macro to specify installing stuff
into $SHAREDIR/tsearch_data/, instead of making everyone reinvent the
hack that's currently in dict_xsyn/Makefile.

I was going to propose calling it DATA_TSEARCH, but DICTFILES would
work too.  Any preferences?

            regards, tom lane

On Tue, Oct 16, 2007 at 10:05:27AM -0400, Tom Lane wrote:
> Magnus Hagander <magnus@hagander.net> writes:
> > Do we expect there might be more like this? We could easily add a rule
> > to Install.pm to know about DICTFILES rules in addition to DATA
> > rules..
>
> Yeah, after sleeping on it I think we need a general-purpose solution.
> There are likely to be more not fewer tsearch-related contrib modules
> in future; and even if you don't believe that, people will certainly
> want to use the PGXS infrastructure to build add-on dictionaries.
> So we should provide a DATA-like macro to specify installing stuff
> into $SHAREDIR/tsearch_data/, instead of making everyone reinvent the
> hack that's currently in dict_xsyn/Makefile.
>
> I was going to propose calling it DATA_TSEARCH, but DICTFILES would
> work too.  Any preferences?

DATA_TSEARCH seems better, it indicates where the files are going even
clearer.

//Magnus

Magnus Hagander <magnus@hagander.net> writes:
> DATA_TSEARCH seems better, it indicates where the files are going even
> clearer.

Done.

            regards, tom lane