Thread: Re: [COMMITTERS] pgsql: Add a note about another issue that needs to be considered before
Re: [COMMITTERS] pgsql: Add a note about another issue that needs to be considered before
From
Tom Lane
Date:
Gregory Stark <stark@enterprisedb.com> writes:
> FWIW I found another issue with this variable when I was experimenting with
> small block sizes. If you set the target <= the tuple header the toaster
> breaks. This is because it's doing unsigned arithmetic (Size is unsigned). I
> think the right solution is just to change it to use plain int32 arithmetic
> everywhere.
Somehow I can't get excited about that. If we ever do open things up to
allow user control of the target, we'd certainly constrain it to a sane
range.
regards, tom lane
Re: pgsql: Add a note about another issue that needs to be considered before
From
Gregory Stark
Date:
"Tom Lane" <tgl@sss.pgh.pa.us> writes: > Gregory Stark <stark@enterprisedb.com> writes: >> FWIW I found another issue with this variable when I was experimenting with >> small block sizes. If you set the target <= the tuple header the toaster >> breaks. This is because it's doing unsigned arithmetic (Size is unsigned). I >> think the right solution is just to change it to use plain int32 arithmetic >> everywhere. > > Somehow I can't get excited about that. If we ever do open things up to > allow user control of the target, we'd certainly constrain it to a sane > range. Yeah, i didn't even mention it at the time. I just thought I would mention it now since you were adding comments on restrictions to the toast threshold. -- Gregory Stark EnterpriseDB http://www.enterprisedb.com Ask me about EnterpriseDB's Slony Replication support!