Thread: Re: [COMMITTERS] pgsql: Some cleanups of enum-guc code, per comments from Tom.
Re: [COMMITTERS] pgsql: Some cleanups of enum-guc code, per comments from Tom.
From
Alvaro Herrera
Date:
Magnus Hagander wrote: > Log Message: > ----------- > Some cleanups of enum-guc code, per comments from Tom. These bits seem to have broken --describe-config: LC_ALL=C postmaster --describe-config > /dev/null internal error: unrecognized run-time parameter type internal error: unrecognized run-time parameter type internal error: unrecognized run-time parameter type internal error: unrecognized run-time parameter type internal error: unrecognized run-time parameter type (Perhaps they were already broken in the previous patch, not sure). -- Alvaro Herrera http://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support
Re: Re: [COMMITTERS] pgsql: Some cleanups of enum-guc code, per comments from Tom.
From
Tom Lane
Date:
Alvaro Herrera <alvherre@commandprompt.com> writes:
> These bits seem to have broken --describe-config:
> (Perhaps they were already broken in the previous patch, not sure).
It was already broken :-(. Not sure how both Magnus and I missed
the switch in help_config.c --- I know I grepped for references to
the PGC_xxx enum constants, and I suppose he did too.
regards, tom lane
Re: Re: [COMMITTERS] pgsql: Some cleanups of enum-guc code, per comments from Tom.
From
Magnus Hagander
Date:
Tom Lane wrote: > Alvaro Herrera <alvherre@commandprompt.com> writes: >> These bits seem to have broken --describe-config: >> (Perhaps they were already broken in the previous patch, not sure). > > It was already broken :-(. Not sure how both Magnus and I missed > the switch in help_config.c --- I know I grepped for references to > the PGC_xxx enum constants, and I suppose he did too. Yeah, that's what I did, and I have no idea how I missed it. Will fix. //Magnus