Thread: Re: [COMMITTERS] pgsql: Make 'find' syntax consistent; add .git exclusion to make_ctags.
Re: [COMMITTERS] pgsql: Make 'find' syntax consistent; add .git exclusion to make_ctags.
From
Alvaro Herrera
Date:
Bruce Momjian wrote: > Log Message: > ----------- > Make 'find' syntax consistent; add .git exclusion to make_ctags. Should this consider the distdir target in /GNUmakefile.in too? -- Alvaro Herrera http://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support
Re: [COMMITTERS] pgsql: Make 'find' syntax consistent; add .git exclusion to make_ctags.
From
Bruce Momjian
Date:
Alvaro Herrera wrote: > Bruce Momjian wrote: > > Log Message: > > ----------- > > Make 'find' syntax consistent; add .git exclusion to make_ctags. > > Should this consider the distdir target in /GNUmakefile.in too? It only is looking for _directories_ to put 'tags' into. -- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + If your life is a hard drive, Christ can be your backup. +
Re: Re: [COMMITTERS] pgsql: Make 'find' syntax consistent; add .git exclusion to make_ctags.
From
Bruce Momjian
Date:
Alvaro Herrera wrote: > Bruce Momjian wrote: > > Log Message: > > ----------- > > Make 'find' syntax consistent; add .git exclusion to make_ctags. > > Should this consider the distdir target in /GNUmakefile.in too? Oh, I get it now, 'distdir'. Let me look. -- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + If your life is a hard drive, Christ can be your backup. +
Re: Re: [COMMITTERS] pgsql: Make 'find' syntax consistent; add .git exclusion to make_ctags.
From
Bruce Momjian
Date:
Alvaro Herrera wrote: > Bruce Momjian wrote: > > Log Message: > > ----------- > > Make 'find' syntax consistent; add .git exclusion to make_ctags. > > Should this consider the distdir target in /GNUmakefile.in too? Uh, I usually run the tag program from the /src directory where there is no 'distdir', but if you want 'distdir' added, just let me know. -- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + If your life is a hard drive, Christ can be your backup. +
Re: Re: [COMMITTERS] pgsql: Make 'find' syntax consistent; add .git exclusion to make_ctags.
From
Alvaro Herrera
Date:
Bruce Momjian wrote: > Alvaro Herrera wrote: > > Bruce Momjian wrote: > > > Log Message: > > > ----------- > > > Make 'find' syntax consistent; add .git exclusion to make_ctags. > > > > Should this consider the distdir target in /GNUmakefile.in too? > > Uh, I usually run the tag program from the /src directory where there is > no 'distdir', but if you want 'distdir' added, just let me know. No, I'm just pointing out that the distdir rule has a find invocation, and it excludes directories named CVS. So if we exclude .git on the make_[ce]tags scripts, maybe we should on make distdir too. On the other hand, I'm not sure who (if anyone) runs make distdir, so maybe this is not an issue. -- Alvaro Herrera http://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support
Re: Re: [COMMITTERS] pgsql: Make 'find' syntax consistent; add .git exclusion to make_ctags.
From
Bruce Momjian
Date:
Alvaro Herrera wrote: > Bruce Momjian wrote: > > Alvaro Herrera wrote: > > > Bruce Momjian wrote: > > > > Log Message: > > > > ----------- > > > > Make 'find' syntax consistent; add .git exclusion to make_ctags. > > > > > > Should this consider the distdir target in /GNUmakefile.in too? > > > > Uh, I usually run the tag program from the /src directory where there is > > no 'distdir', but if you want 'distdir' added, just let me know. > > No, I'm just pointing out that the distdir rule has a find invocation, > and it excludes directories named CVS. So if we exclude .git on the > make_[ce]tags scripts, maybe we should on make distdir too. > > On the other hand, I'm not sure who (if anyone) runs make distdir, so > maybe this is not an issue. Oh, OK, I didn't realize that. Done. -- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + If your life is a hard drive, Christ can be your backup. +
Re: Re: [COMMITTERS] pgsql: Make 'find' syntax consistent; add .git exclusion to make_ctags.
From
Alvaro Herrera
Date:
Bruce Momjian wrote: > Alvaro Herrera wrote: > > Bruce Momjian wrote: > > > Log Message: > > > ----------- > > > Make 'find' syntax consistent; add .git exclusion to make_ctags. > > > > Should this consider the distdir target in /GNUmakefile.in too? > > It only is looking for _directories_ to put 'tags' into. I have to admit that I find this whole idea a bit weird. Is it common to symlink the tags file? What I did was tell my editor that the tags file is to be found on the root source directory. It seems the most natural way to do this. Am I alone in this? -- Alvaro Herrera http://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc.
Re: Re: [COMMITTERS] pgsql: Make 'find' syntax consistent; add .git exclusion to make_ctags.
From
Euler Taveira de Oliveira
Date:
Alvaro Herrera escreveu: > Bruce Momjian wrote: >> Alvaro Herrera wrote: >>> Bruce Momjian wrote: >>>> Log Message: >>>> ----------- >>>> Make 'find' syntax consistent; add .git exclusion to make_ctags. >>> Should this consider the distdir target in /GNUmakefile.in too? >> It only is looking for _directories_ to put 'tags' into. > > I have to admit that I find this whole idea a bit weird. Is it common > to symlink the tags file? > > What I did was tell my editor that the tags file is to be found on the > root source directory. It seems the most natural way to do this. Am I > alone in this? > No, I do it too. -- Euler Taveira de Oliveira http://www.timbira.com/
Re: Re: [COMMITTERS] pgsql: Make 'find' syntax consistent; add .git exclusion to make_ctags.
From
Bruce Momjian
Date:
Euler Taveira de Oliveira wrote: > Alvaro Herrera escreveu: > > Bruce Momjian wrote: > >> Alvaro Herrera wrote: > >>> Bruce Momjian wrote: > >>>> Log Message: > >>>> ----------- > >>>> Make 'find' syntax consistent; add .git exclusion to make_ctags. > >>> Should this consider the distdir target in /GNUmakefile.in too? > >> It only is looking for _directories_ to put 'tags' into. > > > > I have to admit that I find this whole idea a bit weird. Is it common > > to symlink the tags file? > > > > What I did was tell my editor that the tags file is to be found on the > > root source directory. It seems the most natural way to do this. Am I > > alone in this? > > > No, I do it too. Well, I just tell my editor to look for the tags file in the current directory so I don't have to configure it. -- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + If your life is a hard drive, Christ can be your backup. +
Re: Re: [COMMITTERS] pgsql: Make 'find' syntax consistent; add .git exclusion to make_ctags.
From
Alvaro Herrera
Date:
Bruce Momjian wrote: > Euler Taveira de Oliveira wrote: > > Alvaro Herrera escreveu: > > > Bruce Momjian wrote: > > >> Alvaro Herrera wrote: > > >>> Bruce Momjian wrote: > > >>>> Log Message: > > >>>> ----------- > > >>>> Make 'find' syntax consistent; add .git exclusion to make_ctags. > > >>> Should this consider the distdir target in /GNUmakefile.in too? > > >> It only is looking for _directories_ to put 'tags' into. > > > > > > I have to admit that I find this whole idea a bit weird. Is it common > > > to symlink the tags file? > > > > > > What I did was tell my editor that the tags file is to be found on the > > > root source directory. It seems the most natural way to do this. Am I > > > alone in this? > > > > > No, I do it too. > > Well, I just tell my editor to look for the tags file in the current > directory so I don't have to configure it. But you had to configure the make_etags script :-) It just seems that the cruft is in a different place. Don't the tags symlinks show up in diff output and stuff like that? -- Alvaro Herrera http://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc.
Re: Re: [COMMITTERS] pgsql: Make 'find' syntax consistent; add .git exclusion to make_ctags.
From
Bruce Momjian
Date:
Alvaro Herrera wrote: > Bruce Momjian wrote: > > Euler Taveira de Oliveira wrote: > > > Alvaro Herrera escreveu: > > > > Bruce Momjian wrote: > > > >> Alvaro Herrera wrote: > > > >>> Bruce Momjian wrote: > > > >>>> Log Message: > > > >>>> ----------- > > > >>>> Make 'find' syntax consistent; add .git exclusion to make_ctags. > > > >>> Should this consider the distdir target in /GNUmakefile.in too? > > > >> It only is looking for _directories_ to put 'tags' into. > > > > > > > > I have to admit that I find this whole idea a bit weird. Is it common > > > > to symlink the tags file? > > > > > > > > What I did was tell my editor that the tags file is to be found on the > > > > root source directory. It seems the most natural way to do this. Am I > > > > alone in this? > > > > > > > No, I do it too. > > > > Well, I just tell my editor to look for the tags file in the current > > directory so I don't have to configure it. > > But you had to configure the make_etags script :-) It just seems that > the cruft is in a different place. Don't the tags symlinks show up in > diff output and stuff like that? No because they are not part of CVS. -- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + If your life is a hard drive, Christ can be your backup. +