Thread: Re: [COMMITTERS] pgsql: plpython: Add SPI cursor support
Peter Eisentraut <peter_e@gmx.net> writes:
> plpython: Add SPI cursor support
Buildfarm member narwhal does not like this patch. It looks like
"PyObject_SelfIter" is not a compile-time constant on its version
of python (2.5, apparently).
regards, tom lane
On 06/12/11 19:23, Tom Lane wrote: > Peter Eisentraut <peter_e@gmx.net> writes: >> plpython: Add SPI cursor support > > Buildfarm member narwhal does not like this patch. It looks like > "PyObject_SelfIter" is not a compile-time constant on its version > of python (2.5, apparently). Hm, I quickly tried with a self-compiled Python 2.5.6 from the upstream tarball and it compiled on my Linux machine. I see that PyObject_SelfIter is defined here: http://hg.python.org/cpython/file/b48e1b48e670/Include/object.h#l407 I'll try to dig around to see what can be causing that... Cheers, Jan
On 06/12/11 19:33, Jan Urbański wrote: > On 06/12/11 19:23, Tom Lane wrote: >> Peter Eisentraut <peter_e@gmx.net> writes: >>> plpython: Add SPI cursor support >> >> Buildfarm member narwhal does not like this patch. It looks like >> "PyObject_SelfIter" is not a compile-time constant on its version >> of python (2.5, apparently). > > I'll try to dig around to see what can be causing that... Seems that PyObject_GenericGetIter has been renamed to PyObject_SelfIter at some point: http://hg.python.org/cpython/rev/fd5ef7003469 I'm trying to muster whatever mercurial-foo I have to check if there's been a 2.5 version tagged without that patch... Jan
On 07/12/11 11:16, Jan Urbański wrote: > On 06/12/11 19:33, Jan Urbański wrote: >> On 06/12/11 19:23, Tom Lane wrote: >>> Peter Eisentraut <peter_e@gmx.net> writes: >>>> plpython: Add SPI cursor support >>> >>> Buildfarm member narwhal does not like this patch. It looks like >>> "PyObject_SelfIter" is not a compile-time constant on its version >>> of python (2.5, apparently). >> >> I'll try to dig around to see what can be causing that... > > Seems that PyObject_GenericGetIter has been renamed to PyObject_SelfIter > at some point: > > http://hg.python.org/cpython/rev/fd5ef7003469 > > I'm trying to muster whatever mercurial-foo I have to check if there's > been a 2.5 version tagged without that patch... So no, the renaming happened on Mar 17 2003 and 2.5 was tagged on Sep 18 2006. The source tarball for 2.5 contains PyObject_SelfIter. Both fennec and mastodon build OK with Python 2.5. Is it possible that narwhal's Python installation is in some way broken?