Thread: Faster setup_param_list() in plpgsql
Hi all
I am looking on this patch. I can confirm 10-15% speedup - and the idea behind this patch looks well.2015-04-29 9:26 GMT+02:00 Pavel Stehule <pavel.stehule@gmail.com>:
I believe it should be in two separate patches. Refactoring is trivial and there is no any possible objection.b) support for resettable fields in param_list instead total reseta) relative large refactoringThis patch http://www.postgresql.org/message-id/4146.1425872254@sss.pgh.pa.us contains two partsHi allI am looking on this patch. I can confirm 10-15% speedup - and the idea behind this patch looks well.
I was wrong, there is relative strong dependency between these two parts, so it should be commited as one patch
Regards
Pavel
PavelRegards
Review:
What this patch does - it change a mechanism, how a values of variables are transmitted to SPI. In previous variant values are copied to ParamListInfo before every evaluation of any expression. New mechanism is smarter. It refresh only ROW, REC values when are marked as dirty (when these variables was used). ParamListInfo is dynamically updated when value is assigned to variable.
This patch can significantly reduce a overhead related to preparing parameters - more it cleaning code.
2015-04-30 20:50 GMT+02:00 Pavel Stehule <pavel.stehule@gmail.com>:
2015-04-29 9:26 GMT+02:00 Pavel Stehule <pavel.stehule@gmail.com>:I believe it should be in two separate patches. Refactoring is trivial and there is no any possible objection.b) support for resettable fields in param_list instead total reseta) relative large refactoringThis patch http://www.postgresql.org/message-id/4146.1425872254@sss.pgh.pa.us contains two partsHi allI am looking on this patch. I can confirm 10-15% speedup - and the idea behind this patch looks well.I was wrong, there is relative strong dependency between these two parts, so it should be commited as one patchRegardsPavelPavelRegards