Thread: Small typo in timeline.h regarding the meaning of infinity for timeline history entry

Hi all,

timeline.h quotes that the end point of timeline history entry means
infinity when its value is 0. But that's not completely true, I think
that what is meant here is InvalidXLogRecPtr:
 {
        TimeLineID      tli;
        XLogRecPtr      begin;                  /* inclusive */
-       XLogRecPtr      end;                    /* exclusive, 0 means
infinity */
+       XLogRecPtr      end;                    /* exclusive,
InvalidXLogRecPtr means
+                                                                * infinity */
 } TimeLineHistoryEntry;

And the code leads into this direction as well.
Regards,
--
Michael

On Thu, Sep 10, 2015 at 2:37 PM, Michael Paquier
<michael.paquier@gmail.com> wrote:
> Hi all,
>
> timeline.h quotes that the end point of timeline history entry means
> infinity when its value is 0. But that's not completely true, I think
> that what is meant here is InvalidXLogRecPtr:
>  {
>         TimeLineID      tli;
>         XLogRecPtr      begin;                  /* inclusive */
> -       XLogRecPtr      end;                    /* exclusive, 0 means
> infinity */
> +       XLogRecPtr      end;                    /* exclusive,
> InvalidXLogRecPtr means
> +                                                                * infinity */
>  } TimeLineHistoryEntry;
>
> And the code leads into this direction as well.

Thanks for the report and patch! Applied.

Regards,

-- 
Fujii Masao

On Tue, Sep 15, 2015 at 7:38 AM, Fujii Masao wrote:
> Thanks for the report and patch! Applied.

Thanks!
-- 
Michael