Thread: Incorrect comment in contrib/postgres_fdw/deparse.c
Hi, I found an incorrect comment in contrib/postgres_fdw/deparse.c: s/FOR SELECT or FOR SHARE/FOR UPDATE or FOR SHARE/ Attached is a patch to fix that comment. Best regards, Etsuro Fujita
Attachment
Collective typos in contrib/postgres_fdw (Was: Re: Incorrect comment in contrib/postgres_fdw/deparse.c)
From
Etsuro Fujita
Date:
On 2016/04/04 20:11, Etsuro Fujita wrote: > I found an incorrect comment in contrib/postgres_fdw/deparse.c: s/FOR > SELECT or FOR SHARE/FOR UPDATE or FOR SHARE/ Attached is a patch to fix > that comment. Other than this, I ran into some typos in contrib/postgres_fdw, while working on join pushdown improvements. Please find attached an updated version of the patch. Best regards, Etsuro Fujita
Attachment
Re: Collective typos in contrib/postgres_fdw (Was: Re: Incorrect comment in contrib/postgres_fdw/deparse.c)
From
Robert Haas
Date:
On Wed, Aug 24, 2016 at 2:41 AM, Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp> wrote: > On 2016/04/04 20:11, Etsuro Fujita wrote: >> I found an incorrect comment in contrib/postgres_fdw/deparse.c: s/FOR >> SELECT or FOR SHARE/FOR UPDATE or FOR SHARE/ Attached is a patch to fix >> that comment. > > Other than this, I ran into some typos in contrib/postgres_fdw, while > working on join pushdown improvements. Please find attached an updated > version of the patch. Thanks, committed. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Re: Collective typos in contrib/postgres_fdw (Was: Re: Incorrect comment in contrib/postgres_fdw/deparse.c)
From
Etsuro Fujita
Date:
On 2016/08/25 5:29, Robert Haas wrote: > On Wed, Aug 24, 2016 at 2:41 AM, Etsuro Fujita > <fujita.etsuro@lab.ntt.co.jp> wrote: >> On 2016/04/04 20:11, Etsuro Fujita wrote: >>> I found an incorrect comment in contrib/postgres_fdw/deparse.c: s/FOR >>> SELECT or FOR SHARE/FOR UPDATE or FOR SHARE/ Attached is a patch to fix >>> that comment. >> Other than this, I ran into some typos in contrib/postgres_fdw, while >> working on join pushdown improvements. Please find attached an updated >> version of the patch. > Thanks, committed. Thanks for picking this up! Best regards, Etsuro Fujita