Thread: Unused macros in src/include/access/transam.h

Unused macros in src/include/access/transam.h

From

Fabrízio de Royes Mello

Date:

05 April 2016, 19:58:12

Hi all,

When dealing with some patch review I've noticed there are two macro is not used anywhere:

#define TransactionIdStore(xid, dest) (*(dest) = (xid))
#define StoreInvalidTransactionId(dest) (*(dest) = InvalidTransactionId)

Regards,

Fabrízio de Royes Mello
Consultoria/Coaching PostgreSQL

>> Timbira: http://www.timbira.com.br
>> Blog: http://fabriziomello.github.io
>> Linkedin: http://br.linkedin.com/in/fabriziomello
>> Twitter: http://twitter.com/fabriziomello

>> Github: http://github.com/fabriziomello

Re: Unused macros in src/include/access/transam.h

From

Michael Paquier

Date:

05 April 2016, 23:27:14

On Wed, Apr 6, 2016 at 4:55 AM, Fabrízio de Royes Mello
<fabriziomello@gmail.com> wrote:
> Hi all,
>
> When dealing with some patch review I've noticed there are two macro is not
> used anywhere:
>
> #define TransactionIdStore(xid, dest)   (*(dest) = (xid))
> #define StoreInvalidTransactionId(dest) (*(dest) = InvalidTransactionId)

Not by the core code, perhaps they are used by extensions though. The
last bit of code using TransactionIdStore is from 2007 (282d2a03), by
the way. Still, knowing the low level of maintenance those are
requiring, it does not seem worth a compilation breakage I think.
--
Michael