Thread: Leftover member in openssl part of Port struct

When SSL renegotiation was removed in 426746b9 the only consumer of the openssl
specific count member in the Port struct was removed, but the member was left
together with a few updates to it which are unused.  Attached patch removes the
leftovers which now serves no purpose unless I’m missing something.

cheers ./daniel

Daniel Gustafsson <daniel@yesql.se> writes:
> When SSL renegotiation was removed in 426746b9 the only consumer of the openssl
> specific count member in the Port struct was removed, but the member was left
> together with a few updates to it which are unused.  Attached patch removes the
> leftovers which now serves no purpose unless I’m missing something.

Hm, well, we can't remove those case labels as control would then end
up in the default case which throws an error.  But otherwise this seems
sound.  Without renegotiation the count is not very useful anyway
since it's likely to overflow (at least if long is 32 bits).
        regards, tom lane

> On 31 Aug 2016, at 15:12, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> Daniel Gustafsson <daniel@yesql.se> writes:
>> When SSL renegotiation was removed in 426746b9 the only consumer of the openssl
>> specific count member in the Port struct was removed, but the member was left
>> together with a few updates to it which are unused.  Attached patch removes the
>> leftovers which now serves no purpose unless I’m missing something.
>
> Hm, well, we can't remove those case labels as control would then end
> up in the default case which throws an error.

Doh, I’ll go stand in the corner.

> But otherwise this seems
> sound.  Without renegotiation the count is not very useful anyway
> since it's likely to overflow (at least if long is 32 bits).

Yeah. Thanks for applying.

cheers ./daniel