Postgres Pro
Downloads
Home   >   mailing lists

Thread: pg_backup_tar.c seems anerror by win32

pg_backup_tar.c seems anerror by win32

From
"Hiroshi Saito"
Date:
Hi Bruce-san.

Yesterday patch was inadequate....

pg_backup_tar.c: In function `tarOpen':
pg_backup_tar.c:379: `S_IREAD' undeclared (first use in this function)
pg_backup_tar.c:379: (Each undeclared identifier is reported only once
pg_backup_tar.c:379: for each function it appears in.)
pg_backup_tar.c:379: `S_IWRITE' undeclared (first use in this function)
pg_backup_tar.c: In function `_tarAddFile':
pg_backup_tar.c:1051: warning: comparison is always false due to limited range of data type
make[3]: *** [pg_backup_tar.o] Error 1
make[2]: *** [all] Error 2
make[1]: *** [all] Error 2
make: *** [all] Error 2

This patch helps this.
Thanks.

Regards,
Hiroshi Saito
Attachment

Re: pg_backup_tar.c seems anerror by win32

From
Bruce Momjian
Date:
Hiroshi Saito wrote:
> Hi Bruce-san.
>
> Yesterday patch was inadequate....
>
> pg_backup_tar.c: In function `tarOpen':
> pg_backup_tar.c:379: `S_IREAD' undeclared (first use in this function)
> pg_backup_tar.c:379: (Each undeclared identifier is reported only once
> pg_backup_tar.c:379: for each function it appears in.)
> pg_backup_tar.c:379: `S_IWRITE' undeclared (first use in this function)
> pg_backup_tar.c: In function `_tarAddFile':
> pg_backup_tar.c:1051: warning: comparison is always false due to limited range of data type
> make[3]: *** [pg_backup_tar.o] Error 1
> make[2]: *** [all] Error 2
> make[1]: *** [all] Error 2
> make: *** [all] Error 2
>
> This patch helps this.
> Thanks.

Thanks.  Patch applied to HEAD and 8.1.X.

--
  Bruce Momjian   bruce@momjian.us
  EnterpriseDB    http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +