Thread: [pgAdmin4][Patch]: Select2 control destroy issue [Minor fix]

Thanks, applied.

On Friday, October 14, 2016, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote:

Hi

While clicking on Select2 control, it tries to destroy the control and thus it doesn't get this object sometimes and throws error.

It should attempt to destroy the select2 object only if this object is not undefined.

Adds proper check to handle the case.

Please find minor patch and review.

Thanks

Surinder Kumar

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Thanks, applied.

On Fri, Oct 21, 2016 at 3:55 PM, Surinder Kumar
<surinder.kumar@enterprisedb.com> wrote:
> I missed to add the check "destroy only if select2 has destroy property'. in
> previous patch.
> It was reproducible when I select access method of exclusion constraint from
> combo box.
>
> Please find attached patch and review.
>
> On Sat, Oct 15, 2016 at 12:50 AM, Dave Page <dpage@pgadmin.org> wrote:
>>
>> Thanks, applied.
>>
>>
>> On Friday, October 14, 2016, Surinder Kumar
>> <surinder.kumar@enterprisedb.com> wrote:
>>>
>>> Hi
>>>
>>> While clicking on Select2 control, it tries to destroy the control and
>>> thus it doesn't get this object sometimes and throws error.
>>>
>>> It should attempt to destroy the select2 object only if this object is
>>> not undefined.
>>> Adds proper check to handle the case.
>>>
>>> Please find minor patch and review.
>>>
>>> Thanks
>>> Surinder Kumar
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company