Thread: [pgAdmin4][Patch]: RM 1729 Role privileges are badly displayed
Hi All
--

Please find the attached patch to fix the RM #1729 Role privileges are badly displayed
Please review it.
Akshay Joshi
Principal Software Engineer

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246
Mobile: +91 976-788-8246
Attachment
On Fri, Oct 28, 2016 at 10:23 AM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi AllPlease find the attached patch to fix the RM #1729 Role privileges are badly displayedPlease review it.
Hi
This improves the display on the properties dialogue, though it could still make much better use of the space (for example, the switches could almost be right-justified). However, it messes up the Properties pane on the browser, as it shows the switches indented compared to other controls.
Thanks.
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Hi All
--

On Fri, Oct 28, 2016 at 8:53 PM, Dave Page <dpage@pgadmin.org> wrote:
On Fri, Oct 28, 2016 at 10:23 AM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote: Hi AllPlease find the attached patch to fix the RM #1729 Role privileges are badly displayedPlease review it.HiThis improves the display on the properties dialogue, though it could still make much better use of the space (for example, the switches could almost be right-justified). However, it messes up the Properties pane on the browser, as it shows the switches indented compared to other controls.
Attached is the modified patch as per Dave's suggestion. Please review it.
Thanks.--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Akshay Joshi
Principal Software Engineer

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246
Mobile: +91 976-788-8246
Attachment
Thanks, patch applied.
On Tuesday, November 1, 2016, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Tuesday, November 1, 2016, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi AllOn Fri, Oct 28, 2016 at 8:53 PM, Dave Page <dpage@pgadmin.org> wrote:On Fri, Oct 28, 2016 at 10:23 AM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote: Hi AllPlease find the attached patch to fix the RM #1729 Role privileges are badly displayedPlease review it.HiThis improves the display on the properties dialogue, though it could still make much better use of the space (for example, the switches could almost be right-justified). However, it messes up the Properties pane on the browser, as it shows the switches indented compared to other controls.Attached is the modified patch as per Dave's suggestion. Please review it.Thanks.--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Akshay JoshiPrincipal Software EngineerPhone: +91 20-3058-9517
Mobile: +91 976-788-8246
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company