Thread: [HACKERS] invalid number of sync standbys in synchronous_standby_names

Hi,

When the number of sync standbys is set to 0 in s_s_names, the assersion
failure happens as follows. This means that current multiple syncrep code
assumes that the num of sync standbys must be greater than 0. But we forgot
to forbid users from setting that num to 0. This is an oversight in multiple
syncrep patch (so my fault...). Attached patch forbits that.

TRAP: FailedAssertion("!(((bool) 0))", File: "syncrep.c", Line: 711)

Regards,

-- 
Fujii Masao

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Fujii Masao <masao.fujii@gmail.com> writes:
> When the number of sync standbys is set to 0 in s_s_names, the assersion
> failure happens as follows. This means that current multiple syncrep code
> assumes that the num of sync standbys must be greater than 0. But we forgot
> to forbid users from setting that num to 0. This is an oversight in multiple
> syncrep patch (so my fault...). Attached patch forbits that.

Ooops.  Patch looks fine to me.
        regards, tom lane

On Sat, Dec 17, 2016 at 1:00 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Fujii Masao <masao.fujii@gmail.com> writes:
>> When the number of sync standbys is set to 0 in s_s_names, the assersion
>> failure happens as follows. This means that current multiple syncrep code
>> assumes that the num of sync standbys must be greater than 0. But we forgot
>> to forbid users from setting that num to 0. This is an oversight in multiple
>> syncrep patch (so my fault...). Attached patch forbits that.
>
> Ooops.  Patch looks fine to me.

Thanks for the review! Pushed.

Regards,

-- 
Fujii Masao