Thread: Re: [HACKERS] [COMMITTERS] pgsql: Generate fmgr prototypes automatically

Peter Eisentraut <peter_e@gmx.net> writes:
> Generate fmgr prototypes automatically

BTW, I notice some suspicious-looking behavior with -j:

$ make -j8 -s
Writing fmgroids.h
Writing fmgroids.h
Writing postgres.bki
Writing fmgrprotos.h
Writing fmgrtab.c
Writing schemapg.h
Writing postgres.description
Writing postgres.shdescription
Writing fmgrprotos.h
Writing fmgrtab.c
...

Why do fmgroids.h, fmgrprotos.h, and fmgrtab.c now get mentioned
twice?  I suspect there is something broken about the parallelization.
If indeed multiple instances of gmake are writing these files
concurrently, that's likely to result in irreproducible build failures.
        regards, tom lane

On 1/18/17 7:38 AM, Tom Lane wrote:
> Why do fmgroids.h, fmgrprotos.h, and fmgrtab.c now get mentioned
> twice?  I suspect there is something broken about the parallelization.
> If indeed multiple instances of gmake are writing these files
> concurrently, that's likely to result in irreproducible build failures.

I've pushed a fix for this.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> On 1/18/17 7:38 AM, Tom Lane wrote:
>> Why do fmgroids.h, fmgrprotos.h, and fmgrtab.c now get mentioned
>> twice?  I suspect there is something broken about the parallelization.

> I've pushed a fix for this.

Seems to fix the problem for me --- thanks!
        regards, tom lane