Thread: [pgadmin-hackers] [pgAdmin4][Patch] Displaying Zero in Slickgrid editor
[pgadmin-hackers] [pgAdmin4][Patch] Displaying Zero in Slickgrid editor
From
Murtuza Zabuawala
Date:
Hi,
PFA minor patch to display value '0' in Read only text editor.
RM#2138
--
Regards,
Attachment
Hi On Wed, Feb 1, 2017 at 12:18 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: > Hi, > > PFA minor patch to display value '0' in Read only text editor. > RM#2138 Thanks - I committed a modified version of the patch; yours had the same tests duplicated and joined with an or conditional. Please double check it's OK - it looks fine to me and seems to work as expected with null, zero and one. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Re: [pgadmin-hackers] [pgAdmin4][Patch] Displaying Zero in Slickgrid editor
From
Murtuza Zabuawala
Date:
Thanks Dave.
Tested and working fine.
--
Regards,
On Wed, Feb 1, 2017 at 7:20 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi
On Wed, Feb 1, 2017 at 12:18 PM, Murtuza Zabuawala
<murtuza.zabuawala@enterprisedb.com> wrote:
> Hi,
>
> PFA minor patch to display value '0' in Read only text editor.
> RM#2138
Thanks - I committed a modified version of the patch; yours had the
same tests duplicated and joined with an or conditional.
Please double check it's OK - it looks fine to me and seems to work as
expected with null, zero and one.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company