Thread: [COMMITTERS] pgsql: Make walsender always initialize the buffers.
Make walsender always initialize the buffers. Walsender uses the local buffers for each outgoing and incoming message. Previously when creating replication slot, walsender forgot to initialize one of them and which can cause the segmentation fault error. To fix this issue, this commit changes walsender so that it always initialize them before it executes the requested replication command. Back-patch to 9.4 where replication slot was introduced. Problem report and initial patch by Stas Kelvich, modified by me. Report: https://www.postgresql.org/message-id/A1E9CB90-1FAC-4CAD-8DBA-9AA62A6E97C5@postgrespro.ru Branch ------ master Details ------- http://git.postgresql.org/pg/commitdiff/1d04a59be31bf004b880226be0e3fe84acff2815 Modified Files -------------- src/backend/replication/walsender.c | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-)
Fujii Masao <fujii@postgresql.org> writes:
> Make walsender always initialize the buffers.
> ...
> Back-patch to 9.4 where replication slot was introduced.
Doesn't look like you actually pushed the back-patch? I only see
this in HEAD.
regards, tom lane
On Wed, Feb 22, 2017 at 4:04 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote: > Fujii Masao <fujii@postgresql.org> writes: >> Make walsender always initialize the buffers. >> ... >> Back-patch to 9.4 where replication slot was introduced. > > Doesn't look like you actually pushed the back-patch? I only see > this in HEAD. Oh, sorry... I pushed the back-patch. Regards, -- Fujii Masao