Thread: Re: [pgadmin-hackers] [pgAdmin4][PATCH] Fix the issue in browser tree

Hello,

PFA patch to fix the issue in browser tree when adding new node if parent collection node is not loaded.

Fixes: RM#2321

Steps:

1) Open pgAdmin4.

2) Do not expand server-group node.

3) Right click on server-group collection node and add server, now click on save button

(This issue is reproducible on any collection node which is not loaded) 

4) You will see that only newly added node is displayed in browser tree

--

Regards,

Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Thanks - committed!

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

http://www.linkedin.com/in/asheshvashi

On Thu, Apr 6, 2017 at 11:21 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

Hello,

PFA patch to fix the issue in browser tree when adding new node if parent collection node is not loaded.

Fixes: RM#2321

Steps:

1) Open pgAdmin4.

2) Do not expand server-group node.

3) Right click on server-group collection node and add server, now click on save button

(This issue is reproducible on any collection node which is not loaded) 

4) You will see that only newly added node is displayed in browser tree

--

Regards,

Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Hmm, I think this might have broken adding of new nodes in some cases. I just added two new tables (right-clicking the public schema), and had to refresh the tables node before they showed up.

On Fri, Apr 7, 2017 at 4:29 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:

Thanks - committed!

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

http://www.linkedin.com/in/asheshvashi

On Thu, Apr 6, 2017 at 11:21 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

Hello,

PFA patch to fix the issue in browser tree when adding new node if parent collection node is not loaded.

Fixes: RM#2321

Steps:

1) Open pgAdmin4.

2) Do not expand server-group node.

3) Right click on server-group collection node and add server, now click on save button

(This issue is reproducible on any collection node which is not loaded) 

4) You will see that only newly added node is displayed in browser tree

--

Regards,

Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Murtuza - please fix it asap.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

http://www.linkedin.com/in/asheshvashi

On Fri, Apr 7, 2017 at 1:59 PM, Dave Page <dpage@pgadmin.org> wrote:

Hmm, I think this might have broken adding of new nodes in some cases. I just added two new tables (right-clicking the public schema), and had to refresh the tables node before they showed up.

On Fri, Apr 7, 2017 at 4:29 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:

Thanks - committed!

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

http://www.linkedin.com/in/asheshvashi

On Thu, Apr 6, 2017 at 11:21 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

Hello,

PFA patch to fix the issue in browser tree when adding new node if parent collection node is not loaded.

Fixes: RM#2321

Steps:

1) Open pgAdmin4.

2) Do not expand server-group node.

3) Right click on server-group collection node and add server, now click on save button

(This issue is reproducible on any collection node which is not loaded) 

4) You will see that only newly added node is displayed in browser tree

--

Regards,

Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Checking.

--

Regards,

Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Fri, Apr 7, 2017 at 2:13 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:

Murtuza - please fix it asap.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

http://www.linkedin.com/in/asheshvashi

On Fri, Apr 7, 2017 at 1:59 PM, Dave Page <dpage@pgadmin.org> wrote:

Hmm, I think this might have broken adding of new nodes in some cases. I just added two new tables (right-clicking the public schema), and had to refresh the tables node before they showed up.

On Fri, Apr 7, 2017 at 4:29 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:

Thanks - committed!

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

http://www.linkedin.com/in/asheshvashi

On Thu, Apr 6, 2017 at 11:21 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

Hello,

PFA patch to fix the issue in browser tree when adding new node if parent collection node is not loaded.

Fixes: RM#2321

Steps:

1) Open pgAdmin4.

2) Do not expand server-group node.

3) Right click on server-group collection node and add server, now click on save button

(This issue is reproducible on any collection node which is not loaded) 

4) You will see that only newly added node is displayed in browser tree

--

Regards,

Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company