Thread: [HACKERS] pgbench --progress-timestamp no longer works correctly
--progress-timestamp is supposed to make -P report a Unix Epoch time stamp, for easy correlation with the entries in other log files (like the postgres server log file using %n).
But that broke in this commit:
commit 1d63f7d2d180c8708bc12710254eb7b45823440f
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: Mon Jan 2 13:41:51 2017 -0500
Use clock_gettime(), if available, in instr_time measurements.
The commit before that one changed pgbench to make it tolerate the change in clock, but it overlooked --progress-timestamp.
Cheers,
Jeff
On Fri, Apr 07, 2017 at 09:58:07AM -0700, Jeff Janes wrote: > --progress-timestamp is supposed to make -P report a Unix Epoch time stamp, > for easy correlation with the entries in other log files (like the postgres > server log file using %n). > > But that broke in this commit: > > commit 1d63f7d2d180c8708bc12710254eb7b45823440f > Author: Tom Lane <tgl@sss.pgh.pa.us> > Date: Mon Jan 2 13:41:51 2017 -0500 > > Use clock_gettime(), if available, in instr_time measurements. > > > The commit before that one changed pgbench to make it tolerate the change > in clock, but it overlooked --progress-timestamp. [Action required within three days. This is a generic notification.] The above-described topic is currently a PostgreSQL 10 open item. Tom, since you committed the patch believed to have created it, you own this open item. If some other commit is more relevant or if this does not belong as a v10 open item, please let us know. Otherwise, please observe the policy on open item ownership[1] and send a status update within three calendar days of this message. Include a date for your subsequent status update. Testers may discover new open items at any time, and I want to plan to get them all fixed well in advance of shipping v10. Consequently, I will appreciate your efforts toward speedy resolution. Thanks. [1] https://www.postgresql.org/message-id/20170404140717.GA2675809%40tornado.leadboat.com
Noah Misch <noah@leadboat.com> writes:
> On Fri, Apr 07, 2017 at 09:58:07AM -0700, Jeff Janes wrote:
>> --progress-timestamp is supposed to make -P report a Unix Epoch time stamp,
>> for easy correlation with the entries in other log files (like the postgres
>> server log file using %n).
>>
>> But that broke in this commit:
>>
>> commit 1d63f7d2d180c8708bc12710254eb7b45823440f
>> Author: Tom Lane <tgl@sss.pgh.pa.us>
>> Date: Mon Jan 2 13:41:51 2017 -0500
> The above-described topic is currently a PostgreSQL 10 open item. Tom,
> since you committed the patch believed to have created it, you own this open
> item. If some other commit is more relevant or if this does not belong as a
> v10 open item, please let us know. Otherwise, please observe the policy on
> open item ownership[1] and send a status update within three calendar days of
> this message. Include a date for your subsequent status update. Testers may
> discover new open items at any time, and I want to plan to get them all fixed
> well in advance of shipping v10. Consequently, I will appreciate your efforts
> toward speedy resolution. Thanks.
I'll take a look, and either fix it or post another update before the
end of the week.
regards, tom lane
Jeff Janes <jeff.janes@gmail.com> writes:
> --progress-timestamp is supposed to make -P report a Unix Epoch time stamp,
> for easy correlation with the entries in other log files (like the postgres
> server log file using %n).
> But that broke in this commit:
> commit 1d63f7d2d180c8708bc12710254eb7b45823440f
> Author: Tom Lane <tgl@sss.pgh.pa.us>
> Date: Mon Jan 2 13:41:51 2017 -0500
> Use clock_gettime(), if available, in instr_time measurements.
Fixed, thanks. I suspect I missed this spot because it randomly used
INSTR_TIME_GET_MILLISEC instead of INSTR_TIME_GET_DOUBLE; but for
whatever reason, I missed it.
(So presumably, this option never worked properly on Windows ... but
it will now.)
regards, tom lane