Postgres Pro
Downloads
Home   >   mailing lists

Thread: [pgadmin-hackers] [pgAdmin4] To Extract or Not To Extract - That is the Question

[pgadmin-hackers] [pgAdmin4] To Extract or Not To Extract - That is the Question

From
Matthew Kleiman
Date:
Hi Hackers!

We noticed that there have been quite a few Redmine issues that ended up being related to the same function in sqleditor.js. We were wondering if it might be a good idea to extract this function and test it. This would allow us to iterate more quickly and identify potential bugs before they're opened. There have been a few merge conflicts already in this area and without tests it is difficult to resolve these with high confidence. 

The function in question is the callback for onSelectedRangesChanged. In the latest commit on master (12fa02), it's from line 696 to 773.

Inline image 1

Thoughts?

Best,
Sarah & Matt
Attachment

Re: [pgadmin-hackers] [pgAdmin4] To Extract or Not To Extract - That is the Question

From
Dave Page
Date:


On Thu, Jun 1, 2017 at 3:15 PM, Matthew Kleiman <mkleiman@pivotal.io> wrote:
Hi Hackers!

We noticed that there have been quite a few Redmine issues that ended up being related to the same function in sqleditor.js. We were wondering if it might be a good idea to extract this function and test it. This would allow us to iterate more quickly and identify potential bugs before they're opened. There have been a few merge conflicts already in this area and without tests it is difficult to resolve these with high confidence. 

The function in question is the callback for onSelectedRangesChanged. In the latest commit on master (12fa02), it's from line 696 to 773.

Inline image 1


Sounds sensible. Do you have a proposed patch?
 
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachment

Re: [pgadmin-hackers] [pgAdmin4] To Extract or Not To Extract - Thatis the Question

From
Matthew Kleiman
Date:
We are working on this now. Should I open a bug or a feature in redmine to track this work publicly or just keep it in our backlog only?


On Thu, Jun 1, 2017 at 11:11 AM, Dave Page <dpage@pgadmin.org> wrote:


On Thu, Jun 1, 2017 at 3:15 PM, Matthew Kleiman <mkleiman@pivotal.io> wrote:
Hi Hackers!

We noticed that there have been quite a few Redmine issues that ended up being related to the same function in sqleditor.js. We were wondering if it might be a good idea to extract this function and test it. This would allow us to iterate more quickly and identify potential bugs before they're opened. There have been a few merge conflicts already in this area and without tests it is difficult to resolve these with high confidence. 

The function in question is the callback for onSelectedRangesChanged. In the latest commit on master (12fa02), it's from line 696 to 773.




Sounds sensible. Do you have a proposed patch?
 
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] [pgAdmin4] To Extract or Not To Extract - Thatis the Question

From
Dave Page
Date:
On Fri, Jun 2, 2017 at 3:40 PM, Matthew Kleiman <mkleiman@pivotal.io> wrote:
> We are working on this now. Should I open a bug or a feature in redmine to
> track this work publicly or just keep it in our backlog only?

I don't think it needs an RM - users aren't likely to care about it.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company