Thread: [HACKERS] RemoveSubscriptionRel uses simple_heap_delete

Hi,

Currently $subject but should we use CatalogTupleDelete() instead?
It's actually the same behavior though. Other functions use
CatalogTupleXXX(). Attached patch.

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Masahiko Sawada <sawada.mshk@gmail.com> writes:
> Currently $subject but should we use CatalogTupleDelete() instead?
> It's actually the same behavior though. Other functions use
> CatalogTupleXXX(). Attached patch.

Yeah, evidently that patch failed to track the effects of commits
2f5c9d9c9 et al, since it wasn't in-tree yet.  Poking around, at
least statscmds.c has got the same disease.
        regards, tom lane

On Wed, Jun 14, 2017 at 10:44 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Masahiko Sawada <sawada.mshk@gmail.com> writes:
>> Currently $subject but should we use CatalogTupleDelete() instead?
>> It's actually the same behavior though. Other functions use
>> CatalogTupleXXX(). Attached patch.
>
> Yeah, evidently that patch failed to track the effects of commits
> 2f5c9d9c9 et al, since it wasn't in-tree yet.  Poking around, at
> least statscmds.c has got the same disease.
>

Thank you for fixing it!

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center