Thread: [pgAdmin4][Patch]: Dashboard requests don't stop even after closingthe panel
[pgAdmin4][Patch]: Dashboard requests don't stop even after closingthe panel
From
Khushboo Vashi
Date:
Hi,
If we close the Dashboard tab even then the requests don't stop. This is the regression of web-packing of browser.js file.
Please find the attached patch for the same.
Thanks,
Khushboo
Attachment
Re: [pgAdmin4][Patch]: Dashboard requests don't stop even afterclosing the panel
From
Dave Page
Date:
Ashesh, can you deal with this please? Thanks.
On Thu, Jul 27, 2017 at 6:20 AM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,If we close the Dashboard tab even then the requests don't stop. This is the regression of web-packing of browser.js file.Please find the attached patch for the same.Thanks,Khushboo
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Re: [pgAdmin4][Patch]: Dashboard requests don't stop even afterclosing the panel
From
Ashesh Vashi
Date:
On Fri, Jul 28, 2017 at 4:00 PM, Dave Page <dpage@pgadmin.org> wrote:
Ashesh, can you deal with this please? Thanks.
Hi Khushboo,
I've committed the code.
But - I am not able to reopen the dashboard panel once it is closed, even not from the docker context menu -> Add Panel > Dashboard.
I have asked Murtuza to look into it.
--On Thu, Jul 27, 2017 at 6:20 AM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote: Hi,If we close the Dashboard tab even then the requests don't stop. This is the regression of web-packing of browser.js file.Please find the attached patch for the same.Thanks,KhushbooDave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Re: [pgAdmin4][Patch]: Dashboard requests don't stop even afterclosing the panel
From
Murtuza Zabuawala
Date:
Hi Ashesh,
On Mon, Jul 31, 2017 at 4:50 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
On Fri, Jul 28, 2017 at 4:00 PM, Dave Page <dpage@pgadmin.org> wrote:Ashesh, can you deal with this please? Thanks.Hi Khushboo,I've committed the code.But - I am not able to reopen the dashboard panel once it is closed, even not from the docker context menu -> Add Panel > Dashboard.I have asked Murtuza to look into it.
I am able to open Dashboard panel with given steps, I also observed that I'm allowed to open more than one Dashboard panels with same steps.
--On Thu, Jul 27, 2017 at 6:20 AM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote: Hi,If we close the Dashboard tab even then the requests don't stop. This is the regression of web-packing of browser.js file.Please find the attached patch for the same.Thanks,KhushbooDave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company