Thread: [COMMITTERS] pgsql: Add a temp-install prerequisite to "check"-like targets nothavi
[COMMITTERS] pgsql: Add a temp-install prerequisite to "check"-like targets nothavi
From
Noah Misch
Date:
Add a temp-install prerequisite to "check"-like targets not having one. Makefile.global assigns this prerequisite to every target named "check", but similar targets must mention it explicitly. Affected targets failed, tested $PATH binaries, or tested a stale temporary installation. The src/test/modules examples worked properly when called as "make -C src/test/modules/$FOO check", but "make -j" allowed the test to start before the temporary installation was in place. Back-patch to 9.5, where commit dcae5faccab64776376d354decda0017c648bb53 introduced the shared temp-install. Branch ------ REL_10_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/937f67800a7d3c30870af7b1115a76f44bc26e78 Modified Files -------------- src/interfaces/ecpg/test/Makefile | 4 ++-- src/test/locale/Makefile | 1 + src/test/modules/brin/Makefile | 4 ++-- src/test/modules/commit_ts/Makefile | 2 +- src/test/modules/test_pg_dump/Makefile | 2 +- src/test/regress/GNUmakefile | 4 ++-- 6 files changed, 9 insertions(+), 8 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers