Postgres Pro
Downloads
Home   >   mailing lists

Thread: [pgAdmin4][PATCH] To fix dialog help in browser tab/window

[pgAdmin4][PATCH] To fix dialog help in browser tab/window

From
Murtuza Zabuawala
Date:
Hi,

PFA patch to fix the issue where "Dialog Help" was broken in case where query tool/Debugger opens in new browser tab.
RM#2310

Note:
Object help might not work as well when used in new browser tab but for that we might need to find a way to pass node & server information in new browser tab so that we can able to create proper url for given/selected object which requires some time and fortunately we not using Object help button in query tool or debugger at present, meanwhile this patch will fix the issue for dialog help button only.
Attachment

Re: [pgAdmin4][PATCH] To fix dialog help in browser tab/window

From
Akshay Joshi
Date:
Thanks patch applied.

On Thu, Mar 30, 2017 at 7:54 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA patch to fix the issue where "Dialog Help" was broken in case where query tool/Debugger opens in new browser tab.
RM#2310

Note:
Object help might not work as well when used in new browser tab but for that we might need to find a way to pass node & server information in new browser tab so that we can able to create proper url for given/selected object which requires some time and fortunately we not using Object help button in query tool or debugger at present, meanwhile this patch will fix the issue for dialog help button only.


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers




--
Akshay Joshi
Principal Software Engineer 


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246