Thread: [pgAdmin4][Patch]: Do not render security URL in templates if runningin Desktop mode
[pgAdmin4][Patch]: Do not render security URL in templates if runningin Desktop mode
From
Murtuza Zabuawala
Date:
Hi,
PFA patch to fix the issue where we were rendering Security URL's like change password, reset password in HTML templates while running in Desktop mode, we only register these security blueprints in Server mode hence it was failing with BuildError.
RM#2952
Also reverted RM#2922 because it not working as expected and causing runtime to render login screen.
Thanks to Neel for helping me in testing the patch with latest runtime code.
--
Regards,
Attachment
Re: [pgAdmin4][Patch]: Do not render security URL in templates ifrunning in Desktop mode
From
Harshal Dhumal
Date:
Hi Murtuza,
Moving login related code from under decorator @app.before_first_request to @app.before_request
will cause runtime user to login on each request. I think we need to find some better way.
--
Harshal Dhumal
Sr. Software Engineer
On Thu, Dec 14, 2017 at 2:02 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,PFA patch to fix the issue where we were rendering Security URL's like change password, reset password in HTML templates while running in Desktop mode, we only register these security blueprints in Server mode hence it was failing with BuildError.RM#2952Also reverted RM#2922 because it not working as expected and causing runtime to render login screen.Thanks to Neel for helping me in testing the patch with latest runtime code.--Regards,
Re: [pgAdmin4][Patch]: Do not render security URL in templates ifrunning in Desktop mode
From
Murtuza Zabuawala
Date:
Yes Harshal, you are right but due to RM#2922 changes now runtime is rendering the Login page.
@Dave,
Please find updated patch, which will also fix the issue of user login on each request in runtime.
RM#2952
RM#2922
--
MurtuzaOn Thu, Dec 14, 2017 at 2:25 PM, Harshal Dhumal <harshal.dhumal@enterprisedb. com> wrote:
Hi Murtuza,Moving login related code from under decorator @app.before_first_request to @app.before_request will cause runtime user to login on each request. I think we need to find some better way.--Harshal DhumalSr. Software EngineerOn Thu, Dec 14, 2017 at 2:02 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi,PFA patch to fix the issue where we were rendering Security URL's like change password, reset password in HTML templates while running in Desktop mode, we only register these security blueprints in Server mode hence it was failing with BuildError.RM#2952Also reverted RM#2922 because it not working as expected and causing runtime to render login screen.Thanks to Neel for helping me in testing the patch with latest runtime code.--Regards,
Attachment
Re: [pgAdmin4][Patch]: Do not render security URL in templates ifrunning in Desktop mode
From
Dave Page
Date:
Thanks, applied.
On Thu, Dec 14, 2017 at 4:00 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Yes Harshal, you are right but due to RM#2922 changes now runtime is rendering the Login page.@Dave,Please find updated patch, which will also fix the issue of user login on each request in runtime.RM#2952RM#2922-- MurtuzaOn Thu, Dec 14, 2017 at 2:25 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote: Hi Murtuza,Moving login related code from under decorator @app.before_first_request to @app.before_request will cause runtime user to login on each request. I think we need to find some better way.--Harshal DhumalSr. Software EngineerOn Thu, Dec 14, 2017 at 2:02 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi,PFA patch to fix the issue where we were rendering Security URL's like change password, reset password in HTML templates while running in Desktop mode, we only register these security blueprints in Server mode hence it was failing with BuildError.RM#2952Also reverted RM#2922 because it not working as expected and causing runtime to render login screen.Thanks to Neel for helping me in testing the patch with latest runtime code.--Regards,
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company