Thread: [pgAdmin4][RM#3002] To fix the indentation issue in query tool editor
Hi,
PFA patch to fix the issue where Tab key was not working as expected in query tool editor.
Steps to reproduce:
1) Type any multiline sql/text.
2) select the complete sql by pressing Ctrl+A.
3) Press Tab key multiple times, you will see the problem in code indentation.
Please review.
--
Regards,
Attachment
Hello Murtuza,
The patch looks good, and solves the problem. Run the patch on our CI and everything is green.
Thanks
Joao
On Tue, Feb 27, 2018 at 8:11 AM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,PFA patch to fix the issue where Tab key was not working as expected in query tool editor.Steps to reproduce:1) Type any multiline sql/text.2) select the complete sql by pressing Ctrl+A.3) Press Tab key multiple times, you will see the problem in code indentation.Please review.--Regards,
Thank you for testing it Joao.
--
Regards,
Murtuza
On Tue, Feb 27, 2018 at 8:29 PM, Joao De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:
Hello Murtuza,The patch looks good, and solves the problem. Run the patch on our CI and everything is green.ThanksJoaoOn Tue, Feb 27, 2018 at 8:11 AM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi,PFA patch to fix the issue where Tab key was not working as expected in query tool editor.Steps to reproduce:1) Type any multiline sql/text.2) select the complete sql by pressing Ctrl+A.3) Press Tab key multiple times, you will see the problem in code indentation.Please review.--Regards,
Thanks, patch applied.
On Tue, Feb 27, 2018 at 3:00 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Thank you for testing it Joao.--Regards,MurtuzaOn Tue, Feb 27, 2018 at 8:29 PM, Joao De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:Hello Murtuza,The patch looks good, and solves the problem. Run the patch on our CI and everything is green.ThanksJoaoOn Tue, Feb 27, 2018 at 8:11 AM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi,PFA patch to fix the issue where Tab key was not working as expected in query tool editor.Steps to reproduce:1) Type any multiline sql/text.2) select the complete sql by pressing Ctrl+A.3) Press Tab key multiple times, you will see the problem in code indentation.Please review.--Regards,
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company