Postgres Pro
Downloads
Home   >   mailing lists

Thread: [pgAdmin4][RM#3298] Query tool shortcut issue

[pgAdmin4][RM#3298] Query tool shortcut issue

From
Aditya Toshniwal
Date:
Hi Hackers,

PFA patch for query tool keyboard issue where arrow keys were not behaving as expected for execute options dropdown. Also, corrected couple of dropdown HTML codes.

Request you to kindly review.

Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"
Attachment

Re: [pgAdmin4][RM#3298] Query tool shortcut issue

From
Victoria Henry
Date:
Hi Aditya,

The patch looks fine and the tests are passing.

Sincerely,

Victoria & Anthony

On Tue, May 8, 2018 at 8:22 AM, Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

PFA patch for query tool keyboard issue where arrow keys were not behaving as expected for execute options dropdown. Also, corrected couple of dropdown HTML codes.

Request you to kindly review.

Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"

Re: [pgAdmin4][RM#3298] Query tool shortcut issue

From
Akshay Joshi
Date:
Thanks patch applied.

On Tue, May 8, 2018 at 7:29 PM, Victoria Henry <vhenry@pivotal.io> wrote:
Hi Aditya,

The patch looks fine and the tests are passing.

Sincerely,

Victoria & Anthony

On Tue, May 8, 2018 at 8:22 AM, Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

PFA patch for query tool keyboard issue where arrow keys were not behaving as expected for execute options dropdown. Also, corrected couple of dropdown HTML codes.

Request you to kindly review.

Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"




--
Akshay Joshi
Sr. Software Architect


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246