Thread: Incorrect path in header comment identification
Commit ba11258ccb which renamed inet_net_ntop.c in src/backend/utils/adt, and introduced inet_net_ntop.c in src/ports didn’t update the IDENTIFICATION lines in the header comments. Is there a reason to keep the old locations rather than updating to the actual locations as per the below trivial diff? cheers ./daniel diff --git a/src/backend/utils/adt/inet_cidr_ntop.c b/src/backend/utils/adt/inet_cidr_ntop.c index 30b3673789..5a30df16e5 100644 --- a/src/backend/utils/adt/inet_cidr_ntop.c +++ b/src/backend/utils/adt/inet_cidr_ntop.c @@ -14,7 +14,7 @@ * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT * OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. * - * src/backend/utils/adt/inet_net_ntop.c + * src/backend/utils/adt/inet_cidr_ntop.c */ #if defined(LIBC_SCCS) && !defined(lint) diff --git a/src/port/inet_net_ntop.c b/src/port/inet_net_ntop.c index f27fda96ca..90dfeed42d 100644 --- a/src/port/inet_net_ntop.c +++ b/src/port/inet_net_ntop.c @@ -14,7 +14,7 @@ * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT * OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. * - * src/backend/utils/adt/inet_net_ntop.c + * src/port/inet_net_ntop.c */ #if defined(LIBC_SCCS) && !defined(lint)
On Mon, May 14, 2018 at 11:45 AM, Daniel Gustafsson <daniel@yesql.se> wrote:
Commit ba11258ccb which renamed inet_net_ntop.c in src/backend/utils/adt, and
introduced inet_net_ntop.c in src/ports didn’t update the IDENTIFICATION lines
in the header comments. Is there a reason to keep the old locations rather
than updating to the actual locations as per the below trivial diff?
cheers ./daniel
diff --git a/src/backend/utils/adt/inet_cidr_ntop.c b/src/backend/utils/adt/inet_ cidr_ntop.c
index 30b3673789..5a30df16e5 100644
--- a/src/backend/utils/adt/inet_cidr_ntop.c
+++ b/src/backend/utils/adt/inet_cidr_ntop.c
@@ -14,7 +14,7 @@
* ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT
* OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
*
- * src/backend/utils/adt/inet_net_ntop.c
+ * src/backend/utils/adt/inet_cidr_ntop.c
*/
#if defined(LIBC_SCCS) && !defined(lint)
diff --git a/src/port/inet_net_ntop.c b/src/port/inet_net_ntop.c
index f27fda96ca..90dfeed42d 100644
--- a/src/port/inet_net_ntop.c
+++ b/src/port/inet_net_ntop.c
@@ -14,7 +14,7 @@
* ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT
* OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
*
- * src/backend/utils/adt/inet_net_ntop.c
+ * src/port/inet_net_ntop.c
*/
#if defined(LIBC_SCCS) && !defined(lint)
Failed to get the actual patch to apply (probably cut/paste issue from it being inline), but since the changes were trivial, just made those.
Thanks, applied.
--