Postgres Pro
Downloads
Home   >   mailing lists

Thread: [pgAdmin4][Patch] RM #3355 User can not perform operation ofbackup,Backup all, Backup global and Maintenance DB with ssh tunneling

[pgAdmin4][Patch] RM #3355 User can not perform operation ofbackup,Backup all, Backup global and Maintenance DB with ssh tunneling

From
Akshay Joshi
Date:
Hi Hackers,

Attached is the patch to fix RM #3355 User can not perform operation of backup, Backup all, Backup global and Maintenance DB with ssh tunneling.

Please review it.

--
Akshay Joshi
Sr. Software Architect


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246
Attachment

Re: [pgAdmin4][Patch] RM #3355 User can not perform operation ofbackup,Backup all, Backup global and Maintenance DB with ssh tunneling

From
Joao De Almeida Pereira
Date:
Hello Akshay,

Looks like the tests failed, but it is just flakes. We assume no regression was made with this code, despite the fact that no tests were added to ensure the new code is working.

Thanks
Anthony && Joao

On Tue, May 29, 2018 at 6:41 AM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to fix RM #3355 User can not perform operation of backup, Backup all, Backup global and Maintenance DB with ssh tunneling.

Please review it.

--
Akshay Joshi
Sr. Software Architect


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246

Re: [pgAdmin4][Patch] RM #3355 User can not perform operation ofbackup,Backup all, Backup global and Maintenance DB with ssh tunneling

From
Akshay Joshi
Date:
Hi Joao

On Tue, May 29, 2018 at 9:24 PM, Joao De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:
Hello Akshay,

Looks like the tests failed, but it is just flakes. We assume no regression was made with this code, despite the fact that no tests were added to ensure the new code is working.

   Thanks for reviewing it. Yes tests were failed, but it is nothing to do with this patch. I haven't change any logic in feature test. This patch contains the changes where instead of using host and port of the database server it uses 'localhost' and the local bind port returned by SSH Tunnel module. 

   Khushboo has send the patch where she wrote test cases for Utility module (not committed yet) and anyways we can't replicate the SSH Tunnelling scenario using test cases.  

Thanks
Anthony && Joao

On Tue, May 29, 2018 at 6:41 AM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to fix RM #3355 User can not perform operation of backup, Backup all, Backup global and Maintenance DB with ssh tunneling.

Please review it.

--
Akshay Joshi
Sr. Software Architect


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246



--
Akshay Joshi
Sr. Software Architect


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246

Re: [pgAdmin4][Patch] RM #3355 User can not perform operation ofbackup,Backup all, Backup global and Maintenance DB with ssh tunneling

From
Dave Page
Date:
Thanks, applied.

On Tue, May 29, 2018 at 6:41 AM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to fix RM #3355 User can not perform operation of backup, Backup all, Backup global and Maintenance DB with ssh tunneling.

Please review it.

--
Akshay Joshi
Sr. Software Architect


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company