Postgres Pro
Downloads
Home   >   mailing lists

Thread: Test patch for partitionwise join with partitioned tables containingdefault partition

Test patch for partitionwise join with partitioned tables containingdefault partition

From
Rajkumar Raghuwanshi
Date:
Hi,

As of now partition_join.sql is not having test cases covering cases
where partition table have default partition, attaching a small test
case patch to cover those.

Here is a link of previous discussion :
As found by Thomas, The regression test currently fails with v4 patch because a
redundant Result node has been removed from a query plan. here is the updated
v5 patch fixing this.

Thanks & Regards,
Rajkumar Raghuwanshi
QMG, EnterpriseDB Corporation
Attachment

Re: Test patch for partitionwise join with partitioned tablescontaining default partition

From
Ashutosh Bapat
Date:
Thanks Rajkumar for starting a new thread. Please update the
commitfest entry as well.

I have marked this entry as ready for committer, so expecting a
committer to take a look at the patch and commit it.

On Wed, Jun 6, 2018 at 11:26 AM, Rajkumar Raghuwanshi
<rajkumar.raghuwanshi@enterprisedb.com> wrote:
> Hi,
>
> As of now partition_join.sql is not having test cases covering cases
> where partition table have default partition, attaching a small test
> case patch to cover those.
>
> Here is a link of previous discussion :
> https://www.postgresql.org/message-id/CAKcux6%3DLO-XK9G0yLe634%2B0SP2UOn5ksVnmF-OntTBOEEaUGTg%40mail.gmail.com
>
> As found by Thomas, The regression test currently fails with v4 patch
> because a
> redundant Result node has been removed from a query plan. here is the
> updated
> v5 patch fixing this.
>
> Thanks & Regards,
> Rajkumar Raghuwanshi
> QMG, EnterpriseDB Corporation



-- 
Best Wishes,
Ashutosh Bapat
EnterpriseDB Corporation
The Postgres Database Company

Re: Test patch for partitionwise join with partitioned tablescontaining default partition

From
Rajkumar Raghuwanshi
Date:
On Wed, Jun 6, 2018 at 11:32 AM, Ashutosh Bapat <ashutosh.bapat@enterprisedb.com> wrote:
Thanks Rajkumar for starting a new thread. Please update the
commitfest entry as well.
I have attached new thread in commitfest and detached the old one.

Thanks & Regards,
Rajkumar Raghuwanshi
QMG, EnterpriseDB Corporation

Re: Test patch for partitionwise join with partitioned tablescontaining default partition

From
Rajkumar Raghuwanshi
Date:
Thanks for commit Jeff. Thanks for review Ashutosh, Thomas.

commit 4513d3a4be0bb7d0141f8b7eaf669a55c08e41b0
Author: Jeff Davis <jdavis@postgresql.org>
Date:   Thu Jul 5 18:56:12 2018 -0700

    Add test for partitionwise join involving default partition.
   
    Author: Rajkumar Raghuwanshi
    Reviewed-by: Ashutosh Bapat
    Discussion: https://postgr.es/m/CAKcux6ky5YeZAY74qSh-ayPZZEQchz092g71iXXbC0%2BE3xoscA%40mail.gmail.com
    Discussion: https://postgr.es/m/CAKcux6kOQ85Xtzxu3tM1mR7Vk%3D7Z2e4rG7dL1iMZqPgLMpxQYg%40mail.gmail.com

Thanks & Regards,
Rajkumar Raghuwanshi
QMG, EnterpriseDB Corporation

On Wed, Jun 6, 2018 at 12:03 PM, Rajkumar Raghuwanshi <rajkumar.raghuwanshi@enterprisedb.com> wrote:
On Wed, Jun 6, 2018 at 11:32 AM, Ashutosh Bapat <ashutosh.bapat@enterprisedb.com> wrote:
Thanks Rajkumar for starting a new thread. Please update the
commitfest entry as well.
I have attached new thread in commitfest and detached the old one.

Thanks & Regards,
Rajkumar Raghuwanshi
QMG, EnterpriseDB Corporation