Thread: BUG #15252: "do not dump comments" in pg_restore help

The following bug has been logged on the website:

Bug reference:      15252
Logged by:          Andrey Lizenko
Email address:      lizenko79@gmail.com
PostgreSQL version: 11beta1
Operating system:   Ubuntu 16.04 LTS
Description:

pg_restore --help reports "do not dump comments"  instead of  "do not
restore comments":

postgres@db1:~$ pg_restore --help | grep comment
  --no-comments                do not dump comments

The same issue in PostgreSQL devel documentation. 

pg_restore tool by itself works as expected

Hello
Thank you! I recheck behavior too, option works correct and has only wrong description. Simple patch attached.

regards, Sergei

On Mon, Jun 25, 2018 at 01:26:38PM +0300, Sergei Kornilov wrote:
> Thank you! I recheck behavior too, option works correct and has only
> wrong description. Simple patch attached.

This is clearly a copy-pasto from recent commit 1368e92, nice catch.

>        <listitem>
>         <para>
> -        Do not dump comments.
> +        Do not restore comments.
>         </para>
>        </listitem>
>       </varlistentry>

This is not consistent with the other --no-XXX switches, so I have
reworded the documentation fix to be more consistent with the rest and
pushed the patch.  I can confirm as well after some manual testing that
the feature behaves as documented.

Thanks for the report and the patch!
--
Michael