Thread: [pgAdmin4] [RM3862] Fix Dialog tabset keyboard navigation
Attachment
Attachment
Hi Khushboo
Can you please review it.
On Wed, Jan 16, 2019 at 12:55 PM Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi,Please find attached updated patch.In this patch I have fixed two issues:i. Dialog tab navigation should work even if focus is on footer buttons (Save, Cancel, etc..)ii. Focus should be set to first editable element of dialog when tab cycle goes through all editable footer buttons.--Harshal DhumalSr. Software EngineerOn Thu, Jan 10, 2019 at 1:16 PM Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:Hi,This patch fixes Dialog tabset keyboard navigation.This regression was caused due to bootstrap 4 changes.Also I have added jasmine test cases for the same--Harshal DhumalSr. Software Engineer
Akshay Joshi
Sr. Software Architect
Phone: +91 20-3058-9517
Mobile: +91 976-788-8246
Mobile: +91 976-788-8246
The patch looks good to me.
On Mon, Jan 21, 2019 at 4:39 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi KhushbooCan you please review it.On Wed, Jan 16, 2019 at 12:55 PM Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:Hi,Please find attached updated patch.In this patch I have fixed two issues:i. Dialog tab navigation should work even if focus is on footer buttons (Save, Cancel, etc..)ii. Focus should be set to first editable element of dialog when tab cycle goes through all editable footer buttons.--Harshal DhumalSr. Software EngineerOn Thu, Jan 10, 2019 at 1:16 PM Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:Hi,This patch fixes Dialog tabset keyboard navigation.This regression was caused due to bootstrap 4 changes.Also I have added jasmine test cases for the same--Harshal DhumalSr. Software Engineer--Akshay JoshiSr. Software ArchitectPhone: +91 20-3058-9517
Mobile: +91 976-788-8246
Thanks patch applied.
On Tue, Jan 22, 2019 at 2:51 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
The patch looks good to me.On Mon, Jan 21, 2019 at 4:39 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:Hi KhushbooCan you please review it.On Wed, Jan 16, 2019 at 12:55 PM Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:Hi,Please find attached updated patch.In this patch I have fixed two issues:i. Dialog tab navigation should work even if focus is on footer buttons (Save, Cancel, etc..)ii. Focus should be set to first editable element of dialog when tab cycle goes through all editable footer buttons.--Harshal DhumalSr. Software EngineerOn Thu, Jan 10, 2019 at 1:16 PM Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:Hi,This patch fixes Dialog tabset keyboard navigation.This regression was caused due to bootstrap 4 changes.Also I have added jasmine test cases for the same--Harshal DhumalSr. Software Engineer--Akshay JoshiSr. Software ArchitectPhone: +91 20-3058-9517
Mobile: +91 976-788-8246
Akshay Joshi
Sr. Software Architect
Phone: +91 20-3058-9517
Mobile: +91 976-788-8246
Mobile: +91 976-788-8246
Hi,
Please find attached patch to fix dialog tab navigation in backup and restore dialog.
Note: If first control in dialog is bootstrap switch then tab and dialog tab navigation do not work.
This is because bootstrap switch captures all keyboard events and it does not allow them to propagate /bubble up.
As Khushboo is working on new switch control (RM 3051) I haven't fix this issue as a part of this patch.
--
Harshal Dhumal
Sr. Software Engineer
On Tue, Jan 22, 2019 at 4:29 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Thanks patch applied.On Tue, Jan 22, 2019 at 2:51 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:The patch looks good to me.On Mon, Jan 21, 2019 at 4:39 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:Hi KhushbooCan you please review it.On Wed, Jan 16, 2019 at 12:55 PM Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:Hi,Please find attached updated patch.In this patch I have fixed two issues:i. Dialog tab navigation should work even if focus is on footer buttons (Save, Cancel, etc..)ii. Focus should be set to first editable element of dialog when tab cycle goes through all editable footer buttons.--Harshal DhumalSr. Software EngineerOn Thu, Jan 10, 2019 at 1:16 PM Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:Hi,This patch fixes Dialog tabset keyboard navigation.This regression was caused due to bootstrap 4 changes.Also I have added jasmine test cases for the same--Harshal DhumalSr. Software Engineer--Akshay JoshiSr. Software ArchitectPhone: +91 20-3058-9517
Mobile: +91 976-788-8246--Akshay JoshiSr. Software ArchitectPhone: +91 20-3058-9517
Mobile: +91 976-788-8246
Attachment
Thanks patch applied.
On Thu, Jan 24, 2019 at 4:19 PM Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi,Please find attached patch to fix dialog tab navigation in backup and restore dialog.Note: If first control in dialog is bootstrap switch then tab and dialog tab navigation do not work.This is because bootstrap switch captures all keyboard events and it does not allow them to propagate /bubble up.As Khushboo is working on new switch control (RM 3051) I haven't fix this issue as a part of this patch.--Harshal DhumalSr. Software EngineerOn Tue, Jan 22, 2019 at 4:29 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:Thanks patch applied.On Tue, Jan 22, 2019 at 2:51 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:The patch looks good to me.On Mon, Jan 21, 2019 at 4:39 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:Hi KhushbooCan you please review it.On Wed, Jan 16, 2019 at 12:55 PM Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:Hi,Please find attached updated patch.In this patch I have fixed two issues:i. Dialog tab navigation should work even if focus is on footer buttons (Save, Cancel, etc..)ii. Focus should be set to first editable element of dialog when tab cycle goes through all editable footer buttons.--Harshal DhumalSr. Software EngineerOn Thu, Jan 10, 2019 at 1:16 PM Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:Hi,This patch fixes Dialog tabset keyboard navigation.This regression was caused due to bootstrap 4 changes.Also I have added jasmine test cases for the same--Harshal DhumalSr. Software Engineer--Akshay JoshiSr. Software ArchitectPhone: +91 20-3058-9517
Mobile: +91 976-788-8246--Akshay JoshiSr. Software ArchitectPhone: +91 20-3058-9517
Mobile: +91 976-788-8246
Akshay Joshi
Sr. Software Architect
Phone: +91 20-3058-9517
Mobile: +91 976-788-8246
Mobile: +91 976-788-8246