Thread: [pgAdmin4[RM#3948] Fix backform note control style
Hi,
PFA minor patch to fix the style, changed the background colour and text colour so that it can be readable.
--
Regards,
Attachment
Hi Murtuza,
I have reviewed your patch and I feel we need Chethana's suggestion on this.
@ Chethana,
Please have a look the attached screen-shots (Existing_design and Proposed_design). With this patch the Note section design has been changed.
We need your suggestion on this to improve it as I feel it needs improvement.
Thanks,
Khushboo
On Wed, Jan 30, 2019 at 3:52 PM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,PFA minor patch to fix the style, changed the background colour and text colour so that it can be readable.--Regards,
Attachment
Hi Khushboo and Murtuza,
I have attached the improved version of the design, please share your views.
A 'note' text should be always be highlighted rather than keeping it muted (faded coloured text).
---
Chethana kumar
On Wed, Jan 30, 2019 at 4:39 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi Murtuza,I have reviewed your patch and I feel we need Chethana's suggestion on this.@ Chethana,Please have a look the attached screen-shots (Existing_design and Proposed_design). With this patch the Note section design has been changed.We need your suggestion on this to improve it as I feel it needs improvement.Thanks,KhushbooOn Wed, Jan 30, 2019 at 3:52 PM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:Hi,PFA minor patch to fix the style, changed the background colour and text colour so that it can be readable.--Regards,
Chethana Kumar
Principal UI/UX Designer
EnterpriseDB Corporation
The Postgres Database Company
P: +91 86981 57146
Attachment
On Fri, Feb 1, 2019 at 6:42 PM Chethana Kumar <chethana.kumar@enterprisedb.com> wrote:
Hi Khushboo and Murtuza,I have attached the improved version of the design, please share your views.A 'note' text should be always be highlighted rather than keeping it muted (faded coloured text).
Chethana,
Can you please send the color combination, when the note control is appeared under a subnode control (with white background color)?
-- Thanks, Ashesh
---Chethana kumarOn Wed, Jan 30, 2019 at 4:39 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:Hi Murtuza,I have reviewed your patch and I feel we need Chethana's suggestion on this.@ Chethana,Please have a look the attached screen-shots (Existing_design and Proposed_design). With this patch the Note section design has been changed.We need your suggestion on this to improve it as I feel it needs improvement.Thanks,KhushbooOn Wed, Jan 30, 2019 at 3:52 PM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:Hi,PFA minor patch to fix the style, changed the background colour and text colour so that it can be readable.--Regards,--Chethana KumarPrincipal UI/UX DesignerEnterpriseDB CorporationThe Postgres Database CompanyP: +91 86981 57146
Attachment
Ashesh,
It remains same with the white background because the note icon itself enough to grab the attention of the user.
I have attached the design sample as well.
---
Chethana kumar
On Fri, Feb 1, 2019 at 6:45 PM Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
On Fri, Feb 1, 2019 at 6:42 PM Chethana Kumar <chethana.kumar@enterprisedb.com> wrote:
Hi Khushboo and Murtuza,I have attached the improved version of the design, please share your views.A 'note' text should be always be highlighted rather than keeping it muted (faded coloured text).Chethana,Can you please send the color combination, when the note control is appeared under a subnode control (with white background color)?-- Thanks, Ashesh---Chethana kumarOn Wed, Jan 30, 2019 at 4:39 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:Hi Murtuza,I have reviewed your patch and I feel we need Chethana's suggestion on this.@ Chethana,Please have a look the attached screen-shots (Existing_design and Proposed_design). With this patch the Note section design has been changed.We need your suggestion on this to improve it as I feel it needs improvement.Thanks,KhushbooOn Wed, Jan 30, 2019 at 3:52 PM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:Hi,PFA minor patch to fix the style, changed the background colour and text colour so that it can be readable.--Regards,--Chethana KumarPrincipal UI/UX DesignerEnterpriseDB CorporationThe Postgres Database CompanyP: +91 86981 57146
Chethana Kumar
Principal UI/UX Designer
EnterpriseDB Corporation
The Postgres Database Company
P: +91 86981 57146
Attachment
Hi,
PFA updated patch.
Regards,
Murtuza
On Wed, Jan 30, 2019 at 3:52 PM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:Hi,PFA minor patch to fix the style, changed the background colour and text colour so that it can be readable.--Regards,