Thread: pgsql: Reset, not recreate, execGrouping.c style hashtables.

pgsql: Reset, not recreate, execGrouping.c style hashtables.

From

Andres Freund

Date:

09 February 2019, 09:38:56

Reset, not recreate, execGrouping.c style hashtables.

This uses the facility added in the preceding commit to fix
performance issues caused by rebuilding the hashtable (with its
comparator expression being the most expensive bit), after every
reset. That's especially important when the comparator is JIT
compiled.

Bug: #15592 #15486
Reported-By: Jakub Janeček, Dmitry Marakasov
Author: Andres Freund
Discussion:
    https://postgr.es/m/15486-05850f065da42931@postgresql.org
    https://postgr.es/m/20190114180423.ywhdg2iagzvh43we@alap3.anarazel.de
Backpatch: 11, where I broke this in bf6c614a2f2c5

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/35afccaba6d0e0aa14e3d1f859e6d84e69aee2cc

Modified Files
--------------
src/backend/executor/nodeAgg.c            | 34 ++++++++++--------
src/backend/executor/nodeRecursiveunion.c | 27 ++++++++-------
src/backend/executor/nodeSetOp.c          | 25 +++++++-------
src/backend/executor/nodeSubplan.c        | 57 ++++++++++++++++++-------------
4 files changed, 79 insertions(+), 64 deletions(-)