Thread: pgsql: Add viewBox attribute to storage page layout SVG image
Add viewBox attribute to storage page layout SVG image Recently added SVG image for storage page layout lacks a viewBox attribute which seems necessary to ensure propoer rendering. Add it. Author: Jonathan Katz Discussion: https://postgr.es/m/ba31e0e1-4c9b-b309-70e8-8e7ac14fc87e%40postgresql.org Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/29046c44f36099f4c979b1491fcf27db2f9184f9 Modified Files -------------- doc/src/sgml/images/pagelayout.svg | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
On 2019-04-27 17:37, Joe Conway wrote: > Add viewBox attribute to storage page layout SVG image The SVG images are not supposed to be edited. This needs a different solution. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On 4/29/19 2:06 AM, Peter Eisentraut wrote: > On 2019-04-27 17:37, Joe Conway wrote: >> Add viewBox attribute to storage page layout SVG image > > The SVG images are not supposed to be edited. This needs a different > solution. If the viewBox attribute is needed to make this work reasonably and the tool does not produce it, post production editing of the SVG is not such a bad thing IMHO. But in any case, if you expect that no one will edit a text-based file (SVG) that is checked in to git, it ought to be made crystal clear somewhere, and the README is not currently crystal clear on that point. Additionally, this should go on the issues list for pg12. Joe -- Crunchy Data - http://crunchydata.com PostgreSQL Support for Secure Enterprises Consulting, Training, & Open Source Development
Attachment
Joe Conway <mail@joeconway.com> writes:
> On 4/29/19 2:06 AM, Peter Eisentraut wrote:
>> The SVG images are not supposed to be edited. This needs a different
>> solution.
> If the viewBox attribute is needed to make this work reasonably and the
> tool does not produce it, post production editing of the SVG is not such
> a bad thing IMHO.
> But in any case, if you expect that no one will edit a text-based file
> (SVG) that is checked in to git, it ought to be made crystal clear
> somewhere, and the README is not currently crystal clear on that point.
I am confused. Didn't we spend many years looking for a graphics
format that *could* be edited?
regards, tom lane